app/vlinsert/opentelemetry: reject fields with names exceeding 128 bytes#1404
Open
vadimalekseev wants to merge 2 commits into
Open
app/vlinsert/opentelemetry: reject fields with names exceeding 128 bytes#1404vadimalekseev wants to merge 2 commits into
vadimalekseev wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/vlinsert/opentelemetry/pb.go">
<violation number="1" location="app/vlinsert/opentelemetry/pb.go:377">
P2: The field-name length check misses the `.` separator added for nested fields, so over-limit names can still pass.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
vadimalekseev
force-pushed
the
otel-too-long-keys
branch
3 times, most recently
from
b6348a1 to
d7fd27e
Compare
vadimalekseev
force-pushed
the
otel-too-long-keys
branch
from
d7fd27e to
ca330cb
Compare
Signed-off-by: Phuong Le <39565248+func25@users.noreply.github.com>
Member
|
Could you add a regression test for this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should prevent high memory consumption when processing deeply nested structures.
Fixes #1321
Updates #1326