Skip to content

sharedgpures: fix dispatch_close decrementing ref_count for handles that never opened a resource #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avafloww wants to merge 1 commit into
base: bleeding-edge
Choose a base branch
from
+15 −2
Open

sharedgpures: fix dispatch_close decrementing ref_count for handles that never opened a resource #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions dlls/sharedgpures.sys/shared_resource.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,10 @@ static NTSTATUS shared_resource_get_info(struct shared_resource *res, void *buff

static NTSTATUS WINAPI dispatch_create(DEVICE_OBJECT *device, IRP *irp)
{
IO_STACK_LOCATION *stack = IoGetCurrentIrpStackLocation(irp);

stack->FileObject->FsContext = (void *)(UINT_PTR)-1;

irp->IoStatus.u.Status = STATUS_SUCCESS;
IoCompleteRequest(irp, IO_NO_INCREMENT);
return STATUS_SUCCESS;
Expand All @@ -372,9 +376,18 @@ static NTSTATUS WINAPI dispatch_create(DEVICE_OBJECT *device, IRP *irp)
static NTSTATUS WINAPI dispatch_close(DEVICE_OBJECT *device, IRP *irp)
{
IO_STACK_LOCATION *stack = IoGetCurrentIrpStackLocation(irp);
struct shared_resource *res = &resource_pool[ (UINT_PTR) stack->FileObject->FsContext ];
struct shared_resource *res;

if ((UINT_PTR)stack->FileObject->FsContext == (UINT_PTR)-1)
{
irp->IoStatus.u.Status = STATUS_SUCCESS;
IoCompleteRequest(irp, IO_NO_INCREMENT);
return STATUS_SUCCESS;
}

res = &resource_pool[ (UINT_PTR) stack->FileObject->FsContext ];

TRACE("Freeing shared resouce %p.\n", res);
TRACE("Freeing shared resource %p.\n", res);

if (res)
{
Expand Down