Skip to content

A remedy to #217 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepfire wants to merge 17 commits into
base: master
Choose a base branch
from
Open

A remedy to #217 #221

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9994ef8
vogleditor: fix a -Wformat-security violation
Mar 17, 2017
75e21b4
git: a slightly better ignore
Mar 17, 2017
1ce6c33
cmake: add an install spec
Mar 17, 2017
3bd5868
cmake defs: more uniformity and completeness
Mar 17, 2017
ee05fae
vogltrace: put in the ${out}/bin: it's the scenario intended by ups…
Mar 17, 2017
5e200a5
qlaunchtracerdialog: only LD_PRELOAD binary of matching pointer size
Mar 17, 2017
cbc5f18
voglreplay: only LD_PRELOAD binary of matching pointer size
Mar 18, 2017
2a46638
nix: package
Mar 17, 2017
664e55b
travis: add .travis.yml
Mar 21, 2017
44d352b
readme: add a status image
Mar 21, 2017
8b99e22
readme: update
deepfire Mar 22, 2017
9eb7ab1
travis: switch to 8G VMs
deepfire Mar 27, 2017
127e0de
readme | vogleditor: clarify the 32/64 bit preloading controversy
deepfire Mar 31, 2017
2d8bb92
readme: clarify that Mac OS X isn't out of question for Nix-based bu…
deepfire Mar 31, 2017
90ac7e6
nix: update to the recent nixpkgs changes
deepfire Mar 31, 2017
db85683
readme: fix instructions to describe actual installation, not a mere…
deepfire Mar 31, 2017
92b3410
qapicalltreemodel: review suggestions
deepfire May 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vogleditor/vogleditor_qapicalltreemodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ bool vogleditor_QApiCallTreeModel::init(vogl_trace_file_reader *pTrace_reader)
{
QString msg(QString("*** Information: unpaired \"") + QString(g_vogl_entrypoint_descs[entrypoint_id].m_pName) + QString("\"."));
vogleditor_output_message(msg.toStdString().c_str());
vogl_printf(msg.toStdString().c_str());
vogl_printf("%s", msg.toStdString().c_str());
vogl_printf("\n");
Copy link
Copy Markdown

@mgerhardy mgerhardy May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged with the previous line "%s\n"

Copy link
Copy Markdown

@deepfire-pusher deepfire-pusher May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgerhardy, done

}
}
Expand Down Expand Up @@ -387,7 +387,7 @@ bool vogleditor_QApiCallTreeModel::init(vogl_trace_file_reader *pTrace_reader)
{
QString msg(QString("*** Information: unpaired \"") + QString(g_vogl_entrypoint_descs[entrypoint_id].m_pName) + QString("\"."));
vogleditor_output_message(msg.toStdString().c_str());
vogl_printf(msg.toStdString().c_str());
vogl_printf("%s", msg.toStdString().c_str());
vogl_printf("\n");
}
}
Expand Down