Skip to content

Make email optional on customer update #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottsb wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make email optional on customer update #24

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0eef809
make email optional on customer update
scottsb Jan 24, 2018
584efe7
fix undefined variable bug and correct indentation
scottsb Jan 24, 2018
4db5f34
add test
scottsb Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Customerio/Api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function createCustomer($id, $email, $attributes=array())
return $this->request->authenticate($this->siteId, $this->apiSecret)->customer($id, $email, $attributes);
}

public function updateCustomer($id, $email, $attributes=array())
public function updateCustomer($id, $email=null, $attributes=array())
{
return $this->createCustomer($id, $email, $attributes);
}
Expand Down
13 changes: 8 additions & 5 deletions src/Customerio/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ public function __construct($client=null)
*/
public function customer($id, $email, $attributes)
{
$body = array_merge(array('email' => $email), $attributes);
if (is_null($email)) {
$body = $attributes;
} else {
$body = array_merge(array('email' => $email), $attributes);
}

try {
$response = $this->client->put('/api/v1/customers/'.$id, array(
Expand Down Expand Up @@ -183,10 +187,9 @@ public function authenticate($apiKey, $apiSecret)
*/
protected function parseData(array $data)
{
if (empty($data))
{
$data = new stdClass();
}
if (empty($data)) {
$data = new stdClass();
}

return array('data' => $data);
}
Expand Down