Conversation
|
Great to see that you were able to come up with a solution for this problem. Would it be possible to whip up a very simple example plugin which we ideally could include in the demo setup? Or, at least some documentation on how to use this. It would make it a lot easier for me to review. |
|
Sure, can do. Main thing I wanted here was confirmation of the concept, if the concept seems sound then I will work on the stuff that makes it easier for other people to use. |
6f12a23 to
0715e85
Compare
|
@easybe Added an example plugin under |
easybe
left a comment
There was a problem hiding this comment.
Sorry for taking so long.
Seems like a good approach to me.
8589f11 to
451ef92
Compare
|
@jkuri I can't figure out what is wrong with these tests... Getting the following error locally - |
I was wondering why you are using static IP addresses. Why not just use Compose's default network and use host names for addressing? I.e.: instead of: Line 77 in a17e9e9 |
Maybe you didn't wait for them to complete or cancelling them with |
I can update to dynamic ips configuration and use host addresses if you prefer. |
I'm testing this locally right now. Getting a different error, but there's a good chance I have no idea what I'm doing. |
These don't need to be showing in the API docs since that is the docs page.
Any guesses how to fix this? I will push updates to this branch with the rebase so you ca take a better look. |
b7d4fe5 to
5e4ed29
Compare
|
I'll find an issue and let you know. |
|
@b-rowan it should be fixed now, I needed to upgrade |
This adds plugin support for goosebit, allowing extending templates, static files, routing, config data hooks, and update hooks. This is everything we need for our internal plugins, and have been using a form of this for well over a month now with no issues. This is a slightly cleaner implementation of our system that uses a
PluginSchemaclass to define what should be included in the main app.Closes #15