Reject HTTP error responses before partitioning - #4414
Draft
CyMule wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The general URL loader could classify and partition an HTTP error page as if it were the requested document. That makes an unsuccessful fetch look like successful ingestion and can place error-page content in downstream indexes.
The unit-test matrix also exposed a pre-existing race in
test_evaluate.py: parallel pytest workers wrote to and removed the same fixed result directories. One worker could therefore delete a generated TSV before another worker read it.Impact
HTTP 4xx and 5xx responses now fail visibly instead of being partitioned. Successful responses and the existing request timeout behavior are unchanged.
Metrics tests that mutate shared evaluation-result paths now hold a cross-process lock for the duration of each test and its cleanup, preventing xdist workers from deleting one another's outputs.
Validation
uv run --no-sync pytest -q test_unstructured/partition/test_auto.py -k 'rejects_an_error_response'— 1 passeduv run --no-sync pytest -n 8 -q test_unstructured/metrics/test_evaluate.py— 26 passedgit diff --checkpassed