fix: preserve table row boundaries - #4376
Open
2830500285 wants to merge 2 commits into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Shadow auto-approve: would require human review. Changes modify core table text generation logic in HtmlTable, which can affect data extraction from CSV, TSV, XLSX partitions. This is a logic change to a critical path with potential for breaking downstream consumers.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HtmlTable.textby joining cell text per row and separating rows with blank lines.Testing
uv run --no-sync ruff format --check unstructured/common/html_table.py test_unstructured/common/test_html_table.py test_unstructured/partition/test_constants.py test_unstructured/partition/test_csv.py test_unstructured/partition/test_tsv.py test_unstructured/partition/test_xlsx.py && uv run --no-sync ruff check unstructured/common/html_table.py test_unstructured/common/test_html_table.py test_unstructured/partition/test_constants.py test_unstructured/partition/test_csv.py test_unstructured/partition/test_tsv.py test_unstructured/partition/test_xlsx.pyuv run --no-sync pytest test_unstructured/common/test_html_table.py test_unstructured/partition/test_csv.py test_unstructured/partition/test_tsv.py test_unstructured/partition/test_xlsx.py -qNote
scripts/version-sync.sh -c -f unstructured/__version__.py semvercould not complete locally on macOS because the script requires GNU sed >= 4.3;CHANGELOG.mdandunstructured/__version__.pywere manually synced to0.23.3.