-
Notifications
You must be signed in to change notification settings - Fork 335
FIX: ISXB-1319 Input recorder game view focus #2407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MorganHoarau
wants to merge
14
commits into
develop
Choose a base branch
from
fix/ISXB-1319/input-recorder-game-view-focus
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6cff603
Add InputManager isReplayActive flag
MorganHoarau 1a6a6a2
Links ReplayController to InputManager
MorganHoarau d7fa732
Bypass early out UIInputModule processing
MorganHoarau d0f16d8
Update Events.md
MorganHoarau c292149
Update CHANGELOG.md
MorganHoarau 41691cb
format
MorganHoarau 89ffe5f
Adds missing UNITY_EDITOR define
MorganHoarau fa519b6
Address PR feedback
MorganHoarau 082be33
format
MorganHoarau f5bbd8b
Apply suggestion on Doc
MorganHoarau a6394d7
Adds null check in ReplayController disposal
MorganHoarau a4fb82a
Rework impl design
MorganHoarau 0674761
Commit missing local changes
MorganHoarau 820619d
formatter
MorganHoarau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, when this kind of behaviour is needed (with these editor checks all over the place), I wonder if we shouldn't add a proper optional callback for these replay events, e.g.
ReplayBegun, there already seems to be anm_OnFinishedthat could be used to handle the call to editor codeScheduleEndReplayBypass()?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. this could be e.g. (not sure about naming - conceptually)
m_OnReplayStart?();