Repository navigation
docs: document V4 commands and the correct forge install tag - #529
Open
ninglinLiu wants to merge 1 commit into
Open
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
The README command table still matched the pre-V4 layout (0x0e-0x20 unused) while Commands.sol on main defines V4_SWAP and related commands. Refresh the table and note that forge install without a ref can land on v1.6.0, which lacks V4_SWAP — use a 2.x tag or main for V4 guides. Fixes Uniswap#484
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #484.
forge install Uniswap/universal-router(no ref) can resolve to git tagv1.6.0, which does not defineV4_SWAP, while the V4 swapping docs use that command.mainand the2.xtags (e.g.2.2.0) include it.This PR:
contracts/libraries/Commands.solonmain(includingV4_SWAP, position-manager commands, andACROSS_V4_DEPOSIT_V3)@2.2.0or@main, not an unpinned install that may selectv1.6.0Test plan
Commands.solconstantsv1.6.0has noV4_SWAP;2.2.0/maindoAssistance: AI-assisted drafting; I verified the Commands.sol constants and tag contents.