Repository navigation
Conversation
Adds measured submitBid gas and estimation guidance for bidders. ROUTE-2216.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This adds the section "Gas costs on Ethereum mainnet after Glamsterdam" to
docs/TechnicalDocumentation.md. No contract code changes. Ticket: ROUTE-2216 (Linear).After the Glamsterdam activation, each new storage slot costs 97,920 state gas (EIP-8037).
submitBidwrites new slots for the bid, a new checkpoint for the first bid in a block, and a new tick for a new price. Measured bids go from 153,165 to 419,584 gas before the activation to 526,545 to 1,675,364 gas after it. The section lists the measured cases and the factors that change the cost, and asks bidding interfaces and bots to useeth_estimateGas.How Has This Been Tested?
The auction was created through the v2.1.0 factory on a patched anvil fork of Ethereum mainnet, with a test token, ETH and USDC, and no validation hook. Each row is a mined receipt. The ETH rows were also measured on a fork of Sepolia and replayed with
eth_simulateV1on reth and Geth. The client values matched. Raw data and scripts are in the Glamsterdam harness, directorydeployed-contract-gas.Not covered:
exitBid,claimTokens, and auctions with validation hooks or many initialized ticks.Additional context
CONTRIBUTING.md routes pull requests through
dev. The branch is based onmainbecausedevis older thanmainand does not have the current documentation. The target branch is open.