Skip to content

Move common functionality to media plugin base class#936

Open
hmpf wants to merge 8 commits into
Uninett:masterfrom
hmpf:cleanup-destination-plugins
Open

Move common functionality to media plugin base class#936
hmpf wants to merge 8 commits into
Uninett:masterfrom
hmpf:cleanup-destination-plugins

only validate changed data

713e5d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 29, 2026 in 0s

76.70% (-0.66%) compared to eaa3a25

View this Pull Request on Codecov

76.70% (-0.66%) compared to eaa3a25

Details

Codecov Report

❌ Patch coverage is 69.82249% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.70%. Comparing base (eaa3a25) to head (713e5d5).
⚠️ Report is 356 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/notificationprofile/media/base.py 62.10% 36 Missing ⚠️
src/argus/notificationprofile/media/email.py 80.95% 8 Missing ⚠️
src/argus/notificationprofile/media/__init__.py 42.85% 4 Missing ⚠️
src/argus/notificationprofile/serializers.py 89.47% 2 Missing ⚠️
...rc/argus/notificationprofile/media/sms_as_email.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   77.36%   76.70%   -0.66%     
==========================================
  Files         141      141              
  Lines        5548     5667     +119     
==========================================
+ Hits         4292     4347      +55     
- Misses       1256     1320      +64     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.