Add kiosk mode#1970
Conversation
aleksfl
added
frontend
Test results 8 files 1 808 suites 3m 21s ⏱️ Results for commit caaa79d. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1970 +/- ##
==========================================
+ Coverage 88.62% 89.56% +0.94%
==========================================
Files 149 152 +3
Lines 7185 7296 +111
==========================================
+ Hits 6368 6535 +167
+ Misses 817 761 -56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aleksfl
force-pushed
the
add-kiosk-mode
branch
3 times, most recently
from
e2b2244 to
28a973e
Compare
Co-authored-by: Hanne Moa <hanne.moa@sikt.no>
There was a problem hiding this comment.
Kiosk mode sure doesn't look much different than just collapsing the filters, which was already possible - only detectable difference for me is that the footer line is removed and its filter summary moved to the filter row instead (and that isn't very space-saving - at worst, the footer would have just been pushed outside of the viewport in a long incident list)
I think I would prefer an even more minimal kiosk mode, perhaps pushing the "details" to the blue argus navbar instead. Likely the only thing needed in kiosk mode is to print the name of the selected filter, and the timestamp of the last update. But these are just opinions - I think this kiosk mode should be demoed to our NOC to get some actual user feedback.
One potential show-stopper in the details, thoug...
There was a problem hiding this comment.
Works, but I can only know that the kiosk-mode does something by hovering.
I have suggested adding "link", but we could also decide on never using btn-ghost.
There was a discussion at the accessibility group's latest meeting about invisible buttons. Common, but inaccessible. Ditto hiding the link underline. We have the much slopped #1985 which is about the same problem but in other parts of the dashboard.
Another possibility is having a two-pixel border around such buttons (also including the "special filters"-one, but that would have to be fixed in a different PR).
Agreed. |
Co-authored-by: Hanne Moa <hanne.moa@sikt.no>
aleksfl
force-pushed
the
add-kiosk-mode
branch
2 times, most recently
from
de848a8 to
30d8d9b
Compare
|
Look/feel is approved. |
|
Follow-up: how to highlight links in general, what to do with buttons of little importance (like "special filters" in filter box), with updated style guide. |
|
@hmpf @lunkwill42 Current version has been reworked to be even more minimal, I ran a live demo with the NOC and they preferred this version to their previous suggestion. Happy to get feedback on the code now, since the changes have been quite extensive to facilitate the rework. |
| ArgusHtmxPreferencesFactory(user=request.user) | ||
| return request | ||
|
|
||
| def test_given_non_default_sort_field_it_should_apply_secondary_sort(self): |
There was a problem hiding this comment.
From the test code I cannot see that you're testing what you're claiming to test here
| response = incident_list(self._make_request({"sort": "level"})) | ||
| self.assertEqual(response.status_code, 200) | ||
|
|
||
| def test_given_timeframe_in_session_it_should_include_timeframe_in_query(self): |
|
|
||
|
|
||
| class IncidentDetailTests(test.TestCase): | ||
| def test_given_existing_incident_it_should_render_detail(self): |
Co-authored-by: Johanna England <johanna.england@sikt.no>
|
5 participants
Scope and purpose
Fixes #1938 .
Before:
After:
Adds some extra tests to pad the coverage.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.