Skip to content

Linfeng - Second PR of c++ thermo using pybind11 #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gitlinffff wants to merge 48 commits into
base: main
Choose a base branch
from

wip

90e1c85
Select commit
Loading
Failed to load commit list.
Draft

Linfeng - Second PR of c++ thermo using pybind11 #3874

wip
90e1c85
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jul 21, 2025 in 0s

34 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 34
           

Complexity increasing per file
==============================
- src/constants.cpp  1
- src/thermo.cpp  52
- src/math.cpp  5
- src/calcmod.cpp  2

See the complete overview on Codacy

Annotations

Check warning on line 1 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L1 

Include file: <pybind11/pybind11.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 2 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L2 

Include file: <pybind11/numpy.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 3 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L3 

Include file: <pybind11/stl.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 6 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L6 

Include file: <utility> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 8 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L8 

Include file: <iostream> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 1 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L1 

Include file: <pybind11/pybind11.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 2 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L2 

Include file: <pybind11/numpy.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 3 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L3 

Include file: <cmath> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 5 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L5 

Include file: <vector> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 6 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L6 

Include file: <tuple> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 9 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L9 

Include file: <iostream> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 10 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L10 

Include file: <limits> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 34 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L34 

Function parameter 'phase' should be passed by const reference.

Check warning on line 320 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L320 

Function parameter 'phase' should be passed by const reference.

Check warning on line 346 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L346 

Function parameter 'phase' should be passed by const reference.

Check warning on line 361 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L361 

Function parameter 'phase' should be passed by const reference.

Check warning on line 372 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L372 

Function parameter 'phase' should be passed by const reference.

Check warning on line 5 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L5 

Include file: <pybind11/numpy.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 6 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L6 

Include file: <string> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 7 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L7 

Include file: <vector> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 8 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L8 

Include file: <utility> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 48 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L48 

struct member 'ParProStruct::press_lower' is never used.

Check warning on line 49 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L49 

struct member 'ParProStruct::press_lcl' is never used.

Check warning on line 50 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L50 

struct member 'ParProStruct::temp_lower' is never used.

Check warning on line 51 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L51 

struct member 'ParProStruct::temp_lcl' is never used.
View more details on Codacy Production