Skip to content

Linfeng - First PR of c++ thermo using pybind11 #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gitlinffff wants to merge 41 commits into
base: main
Choose a base branch
from

code convention check

9dbc348
Select commit
Loading
Failed to load commit list.
Draft

Linfeng - First PR of c++ thermo using pybind11 #3856

code convention check
9dbc348
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jul 21, 2025 in 0s

34 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 34
           

Complexity increasing per file
==============================
- src/constants.cpp  1
- src/thermo.cpp  67
- src/math.cpp  5
- src/calcmod.cpp  2
         

Clones added
============
- src/thermo.cpp  2

See the complete overview on Codacy

Annotations

Check warning on line 1 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L1 

Include file: <pybind11/pybind11.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 2 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L2 

Include file: <pybind11/numpy.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 3 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L3 

Include file: <pybind11/stl.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 6 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L6 

Include file: <utility> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 8 in src/calcmod.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/calcmod.cpp#L8 

Include file: <iostream> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 3 in src/constants.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/constants.cpp#L3 

Include file: <pybind11/pybind11.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 1 in src/math.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/math.cpp#L1 

Include file: <cmath> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 1 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L1 

Include file: <pybind11/pybind11.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 2 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L2 

Include file: <pybind11/numpy.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 3 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L3 

Include file: <cmath> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 5 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L5 

Include file: <vector> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 6 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L6 

Include file: <tuple> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 9 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L9 

Include file: <iostream> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 10 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L10 

Include file: <limits> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 34 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L34 

Function parameter 'phase' should be passed by const reference.

Check warning on line 435 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L435 

Function parameter 'phase' should be passed by const reference.

Check warning on line 450 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L450 

Function parameter 'phase' should be passed by const reference.

Check warning on line 461 in src/thermo.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.cpp#L461 

Function parameter 'phase' should be passed by const reference.

Check warning on line 5 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L5 

Include file: <pybind11/numpy.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 6 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L6 

Include file: <string> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 7 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L7 

Include file: <vector> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 8 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L8 

Include file: <utility> not found. Please note: Cppcheck does not need standard library headers to get proper results.

Check warning on line 55 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L55 

struct member 'ParProStruct::press_lcl' is never used.

Check warning on line 56 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L56 

struct member 'ParProStruct::temp_lower' is never used.

Check warning on line 57 in src/thermo.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/thermo.hpp#L57 

struct member 'ParProStruct::temp_lcl' is never used.
View more details on Codacy Production