Allow forks to run benchmarks and comment#1552
Closed
cmdupuis3 wants to merge 1 commit into
Closed
Conversation
Fork PRs get a read-only GITHUB_TOKEN, so the benchmark workflow's inline comment step fails with 403. Split into two workflows: the pull_request job runs benchmarks (read-only) and uploads results + PR number as an artifact; a new workflow_run job posts the comment from the default branch with the repo's write token. The comment job never checks out PR code, keeping the write token safe. Fixes #1547.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test PR for #1551.
Fork PRs get a read-only GITHUB_TOKEN, so the benchmark workflow's inline comment step fails with 403. Split into two workflows: the pull_request job runs benchmarks (read-only) and uploads results + PR number as an artifact; a new workflow_run job posts the comment from the default branch with the repo's write token. The comment job never checks out PR code, keeping the write token safe. Fixes #1547.