Skip to content

fix(ui5-toolbar): fix padding variable swap, item spacing, and Toolba… #13593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PetyaMarkovaBogdanova wants to merge 4 commits into from
+5 −8
Closed

fix(ui5-toolbar): fix padding variable swap, item spacing, and Toolba… #13593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da81760
fix(ui5-toolbar): fix padding variable swap, item spacing, and Toolba…
Copilot May 13, 2026
3528216
fix(ui5-toolbar): fixed failing test
PetyaMarkovaBogdanova May 29, 2026
964d7a2
fix(ui5-toolbar): fixed failing test
PetyaMarkovaBogdanova Jun 2, 2026
b5298b5
Merge branch 'main' into fix-toolbar-findings
PetyaMarkovaBogdanova Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/themes/Toolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
justify-content: flex-end;
box-sizing: border-box;
border-bottom: var(--sapGroup_TitleBorderWidth) solid var(--sapGroup_TitleBorderColor);
padding: 0 var(--_ui5-toolbar-padding-left) 0 var(--_ui5-toolbar-padding-right);
padding: 0 var(--_ui5-toolbar-padding-right) 0 var(--_ui5-toolbar-padding-left);
background-color: var(--sapToolbar_Background);
}

Expand Down
1 change: 0 additions & 1 deletion packages/main/src/themes/ToolbarItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
:host {
display: inline-block;
height: 100%;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/themes/base/Toolbar-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
--_ui5-toolbar-padding-left: 0.5rem;
--_ui5-toolbar-padding-right: 0.5rem;
--_ui5-toolbar-item-margin-left: 0;
--_ui5-toolbar-item-margin-right: 0.25rem;
--_ui5-toolbar-item-margin-right: 0.5rem;
}
Loading