Repository navigation
Conversation
deploy_preview installs @typeform/jarvis (needs @octokit/rest@22) on top of a lockfile that also has @octokit/rest@16 via lerna. Yarn 1 nests rest@16's sub-dependencies under rest@22, so endpoint@6 resolves is-plain-object@2 and crashes with "isPlainObject.isPlainObject is not a function". Resolve @octokit/rest to ^22.0.1 so only one version is installed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e e2e The hosted form now renders the echo-rx OpinionScale, which does not emit data-qa-index (only the legacy Sampler component did), so [data-qa-index="10"] is never found. Select the Radix radio by role and value instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mfrederic
changed the title
…and reload e2e The hosted form now renders the echo-rx OpinionScale, which emits neither data-value-number nor data-qa-index. Select the Radix radio by role and value instead, as done for auto-close. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mfrederic
force-pushed
the
fix/NOJIRA-123_octokit_rest_resolution
branch
from
October 7, 2026 10:29
4845d53 to
1056e26
Compare
Collaborator
|
[BOT] Preview available with hash |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two CI failures that predate #769 and show up on every recent branch.
1.
deploy_preview: jarvis crashCI runs
yarn add -W @typeform/jarvison top ofyarn install --frozen-lockfile. Jarvis (25.1.18) needs@octokit/rest@^22, but the lockfile also has@octokit/rest@^16vialerna→@lerna/github-client. Yarn 1 hoists rest@22 to the root and nests rest@16's sub-dependencies (request@5,endpoint@6) under it, whileis-plain-object@5lands under@lerna/github-client. The nestedendpoint@6then resolves the rootis-plain-object@2, which has noisPlainObjectnamed export. Jarvis is installed unpinned, so a recent jarvis release triggered it.Fix:
"@octokit/rest": "^22.0.1"inresolutions, so only one version is installed.lernaonly uses the GitHub client forlerna publish --create-release, which this repo doesn't use.yarn.lockregenerated viayarn install; besides octokit packages, yarn pruned the unused@typeform/embed@5.5.1and@typeform/embed-react@4.7.0entries.Verified in a clean copy: frozen install then
yarn add -W @typeform/jarvisgives no nested@octokit/rest/node_modules, and the jarvis binary starts without the error.2.
functional: auto-close e2eauto-close.cy.ts(JS and HTML tests) timed out on[data-qa-index="10"]. The test opens the hosted demo form (HLjqXS5W), whose opinion scale is now rendered by echo-rx. Echo-rx (RadixRadioGroup) never emitsdata-qa-index; only the legacy Sampler component did, and the renderer repo removed that fallback in Sept 2026 (renderer#1474, blocks#3105).Fix: select the radio by role and value:
button[role="radio"][value="10"]. I checked this selector against the live form's DOM in a browser; the updated spec has not been run in Cypress locally, so this PR's CI is the first real run.Not addressed
visual(mobile fullscreen VRT diffs) and the PR size labeler (401, likely missingpull-requests: write) are separate.🤖 Generated with Claude Code