reapply gromit config to main #254
Draft
probelabs / Visor: quality
failed
Nov 26, 2025 in 1m 7s
🚨 Check Failed
quality check failed because fail_if condition was met.
Details
📊 Summary
- Total Issues: 6
- Critical Issues: 1
- Error Issues: 2
- Warning Issues: 3
🔍 Failure Condition Results
Failed Conditions
- global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
- Severity: ❌ error
Issues by Category
Logic (3)
- 🚨 ci/goreleaser/goreleaser.yml:134 - The
nfpmsconfiguration for thestdpackage (tyk-ai-studio) is missing thecontentssection that includes the example configuration file (tyk-ai-studio.conf.example), default environment file (/etc/default/tyk-ai-studio), and templates (templates/*). These files were present in the previous configuration. Their absence will likely cause the application to fail at startup, as the Docker container'sCMDpoints to a config file that will not exist. - ❌ .github/workflows/release.yml:334 - The package upgrade test jobs (
upgrade-debandupgrade-rpm) suppress errors when attempting to install a previous version of the package by using|| echo "...". This makes the test unreliable, as any genuine failure during this step (e.g., repository misconfiguration, network issues) will be silently ignored, potentially giving a false positive test result. - ❌ system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
Architecture (1)
⚠️ .github/workflows/release.yml:381 - Theupgrade-rpmtest job usesrpm -Uvh --forceto install the package. The--forceflag can mask important issues such as file conflicts or dependency problems, allowing the test to pass even if the package would fail to install in a real-world scenario. Tests should mimic production installations as closely as possible.
Style (2)
⚠️ .github/workflows/release.yml:41 - The frontend build job setsCI=false. For many frontend build tools, such as Create React App,CI=trueenables stricter checks and treats warnings as errors. Building withCI=falsemay hide potential issues in the frontend code that should be addressed.⚠️ ci/Dockerfile.std:29 - There is a naming inconsistency in the Dockerfile. TheENTRYPOINTuses the binaryai-studio, while theCMDrefers to a configuration file namedtyk-ai-studio.conf. This inconsistency can be confusing for users and maintainers. A consistent naming scheme for the application binary, configuration files, and directories should be used.
Powered by Visor from Probelabs
💡 TIP: You can chat with Visor using /visor ask <your question>
Annotations
Check failure on line 158 in ci/goreleaser/goreleaser.yml
probelabs / Visor: quality
logic Issue
The `nfpms` configuration for the `std` package (`tyk-ai-studio`) is missing the `contents` section that includes the example configuration file (`tyk-ai-studio.conf.example`), default environment file (`/etc/default/tyk-ai-studio`), and templates (`templates/*`). These files were present in the previous configuration. Their absence will likely cause the application to fail at startup, as the Docker container's `CMD` points to a config file that will not exist.
Raw output
Add the `contents` section back to the `nfpms` configuration for the `std` package, similar to how it was in the old configuration, to ensure all necessary files are included in the final package.
Check failure on line 378 in .github/workflows/release.yml
probelabs / Visor: quality
logic Issue
The package upgrade test jobs (`upgrade-deb` and `upgrade-rpm`) suppress errors when attempting to install a previous version of the package by using `|| echo "..."`. This makes the test unreliable, as any genuine failure during this step (e.g., repository misconfiguration, network issues) will be silently ignored, potentially giving a false positive test result.
Raw output
Instead of suppressing errors, check if the previous package version exists before attempting installation. If it doesn't, skip the step with a notice. If it does exist and fails to install, the job should fail to indicate a problem.
Check warning on line 381 in .github/workflows/release.yml
probelabs / Visor: quality
architecture Issue
The `upgrade-rpm` test job uses `rpm -Uvh --force` to install the package. The `--force` flag can mask important issues such as file conflicts or dependency problems, allowing the test to pass even if the package would fail to install in a real-world scenario. Tests should mimic production installations as closely as possible.
Raw output
Remove the `--force` flag from the `rpm -Uvh` command to ensure the test accurately reflects a standard package installation and catches potential conflicts.
Check warning on line 41 in .github/workflows/release.yml
probelabs / Visor: quality
style Issue
The frontend build job sets `CI=false`. For many frontend build tools, such as Create React App, `CI=true` enables stricter checks and treats warnings as errors. Building with `CI=false` may hide potential issues in the frontend code that should be addressed.
Raw output
Set `CI=true` to enforce stricter build checks, or remove the `CI` environment variable to use the default behavior of the CI environment, which is typically `true`.
Check warning on line 30 in ci/Dockerfile.std
probelabs / Visor: quality
style Issue
There is a naming inconsistency in the Dockerfile. The `ENTRYPOINT` uses the binary `ai-studio`, while the `CMD` refers to a configuration file named `tyk-ai-studio.conf`. This inconsistency can be confusing for users and maintainers. A consistent naming scheme for the application binary, configuration files, and directories should be used.
Raw output
Consider renaming the configuration file to `ai-studio.conf` to match the binary name for better consistency. This change would need to be reflected in the packaging configuration (`goreleaser.yml`) and installation scripts as well.
Loading