Skip to content

Remove JavaScript package support from MRL config #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfedderly merged 1 commit into from
Apr 28, 2026
+13 −26
Merged

Remove JavaScript package support from MRL config #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 12 additions & 25 deletions .monorepolint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,12 @@ import {
REMOVE,
} from "@monorepolint/rules";

const TS_PACKAGES = []; // projects that use typescript to build
const JS_PACKAGES = []; // projects that use javascript/rollup to build
const PACKAGES = []; // packages that aren't @turf/turf
const MAIN_PACKAGE = "@turf/turf";

const TAPE_PACKAGES = []; // projects that have tape tests
const TYPES_PACKAGES = []; // projects that have types tests
const TSTYCHE_PACKAGES = []; // projects that use tstyche for type tests.
const BENCH_PACKAGES = []; // projects that have benchmarks
const TAPE_PACKAGES = []; // packages that have tape tests
const TYPES_PACKAGES = []; // packages that have types tests
const TSTYCHE_PACKAGES = []; // packages that use tstyche for type tests.

// iterate all the packages and figure out what buckets everything falls into
const packagesPath = path.join(process.cwd(), "packages");
Expand All @@ -32,11 +30,7 @@ for (const pk of await fs.readdir(packagesPath)) {
await fs.readFile(path.join(packagesPath, pk, "package.json"), "utf8")
).name;

if (existsSync(path.join(packagesPath, pk, "index.ts"))) {
TS_PACKAGES.push(name);
} else {
JS_PACKAGES.push(name);
}
PACKAGES.push(name);

if (existsSync(path.join(pk, "test.js"))) {
TAPE_PACKAGES.push(name);
Expand All @@ -51,13 +45,6 @@ for (const pk of await fs.readdir(packagesPath)) {
}
}

const TS_TAPE_PACKAGES = TAPE_PACKAGES.filter(
(pkg) => -1 !== TS_PACKAGES.indexOf(pkg)
);
const JS_TAPE_PACKAGES = TAPE_PACKAGES.filter(
(pkg) => -1 !== JS_PACKAGES.indexOf(pkg)
);

export default {
rules: [
packageOrder({
Expand Down Expand Up @@ -157,7 +144,7 @@ export default {
},
},
},
includePackages: [...TS_PACKAGES, ...JS_PACKAGES],
includePackages: PACKAGES,
}),

packageEntry({
Expand All @@ -166,7 +153,7 @@ export default {
files: ["dist"],
},
},
includePackages: [...TS_PACKAGES, ...JS_PACKAGES],
includePackages: PACKAGES,
}),

packageEntry({
Expand All @@ -193,7 +180,7 @@ export default {
build: "tsup --config ../../tsup.config.ts",
},
},
includePackages: [...TS_PACKAGES, ...JS_PACKAGES],
includePackages: PACKAGES,
}),

packageScript({
Expand All @@ -213,7 +200,7 @@ export default {
"test:tape": "tsx test.ts",
},
},
includePackages: [...TS_TAPE_PACKAGES, ...JS_TAPE_PACKAGES],
includePackages: TAPE_PACKAGES,
}),

packageScript({
Expand Down Expand Up @@ -245,7 +232,7 @@ export default {
tsx: "^4.19.4",
},
},
includePackages: [...TS_PACKAGES, ...JS_PACKAGES],
includePackages: PACKAGES,
}),

requireDependency({
Expand All @@ -259,7 +246,7 @@ export default {
typescript: "^5.8.3",
},
},
includePackages: TS_PACKAGES,
includePackages: PACKAGES,
}),

requireDependency({
Expand All @@ -277,7 +264,7 @@ export default {
"@types/geojson": "^7946.0.10",
},
},
includePackages: [MAIN_PACKAGE, ...TS_PACKAGES, ...JS_PACKAGES],
includePackages: [MAIN_PACKAGE, ...PACKAGES],
}),
],
};
2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ JSDoc comments are found in the top-level index file for each package (for examp

We have lots of tooling dedicated to ensuring consistent code. We use [Prettier](https://prettier.io/), [TypeScript](https://www.typescriptlang.org/), and [ESLint](https://eslint.org/) to help us deliver quality code. These are checked by the build system and should be enforced at commit time by [Husky](https://typicode.github.io/husky/#/).

Most packages are written in TypeScript, while a few plain Javascript still linger. You can generally use modern Javascript when modifying Turf itself as all exported code is transpiled to (currently es2017).
Packages are written in TypeScript. You can generally use modern TypeScript when modifying Turf itself as all exported code is transpiled to a more compatible subset (currently es2017).

Code for consumption by browsers is transpiled by Babel as described in the README.

Expand Down
Loading