-
Notifications
You must be signed in to change notification settings - Fork 1k
Speed up development builds and drop tsup #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
smallsaucepan
wants to merge
18
commits into
Turfjs:master
Choose a base branch
from
smallsaucepan:dev-without-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4bc86a0
Minimal changes required to have existing ESM+CJS build process compl…
smallsaucepan 6da37b9
Added rules to monorepolint to generate per package tsconfig.json and…
smallsaucepan cfc3c7d
Split @turf/turf build into build and rollup, and moved rollup to the…
smallsaucepan 8b9b2a4
Auto generated (by mrl) changes to existing tsconfig.json and package…
smallsaucepan 26162d8
Auto generated (by mrl) NEW tsconfig.build.json, tsconfig.types.json,…
smallsaucepan 9892d32
Removed now defunct (I think) seperate build tsconfig and tsup config…
smallsaucepan 636eaf0
Merge branch 'Turfjs:master' into dev-without-build
smallsaucepan 5caa61d
WIP.
smallsaucepan b3f2903
Merge remote-tracking branch 'refs/remotes/origin/dev-without-build' …
smallsaucepan 02a8b4d
Merge branch 'master' into dev-without-build
smallsaucepan 2f579b3
Migrate @turf/buffer to TypeScript, ignoring errors
mfedderly 7c4b76f
Merge remote-tracking branch 'upstream/mf/buffer-ts-basic' into dev-w…
smallsaucepan 7847682
Merge branch 'master' into dev-without-build
smallsaucepan 1ae24d0
Retired tsup for JS generation. Instead using tsc with two configs in…
smallsaucepan c1e9d9f
Being explicit about when we are exporting types. Related to enabling…
smallsaucepan 7ed0c48
Merge branch 'master' into dev-without-build
smallsaucepan c289319
Refactor build targets in normal packages to build (esm only) and pre…
smallsaucepan 5acee45
Work in progress. Utilise eslint and prettier built in caching. Test …
smallsaucepan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,4 +35,5 @@ node_modules | |
|
|
||
| .nx/ | ||
| .cursor/rules/nx-rules.mdc | ||
| .eslintcache | ||
| .github/instructions/nx.instructions.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,18 +2,26 @@ | |
| "private": true, | ||
| "funding": "https://opencollective.com/turf", | ||
| "scripts": { | ||
| "build": "tsc -b", | ||
| "dependencies": "tsc -b", | ||
| "docs": "node ./scripts/generate-readmes.mts", | ||
| "escheck": "pnpm run /escheck:.*/", | ||
| "escheck:cjs": "es-check es8 packages/*/dist/cjs/index.js packages/turf/turf.min.js", | ||
| "escheck:esm": "es-check --module es8 packages/*/dist/esm/index.js", | ||
| "escheck:web": "es-check es5 packages/turf/turf.min.js", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lmao we're still shipping es5 turf.min.js. That should definitely get bumped way forward. |
||
| "lint": "pnpm run /lint:.*/", | ||
| "lint:docs": "documentation lint packages/turf-*/index.js", | ||
| "lint:escheck-cjs": "es-check es8 packages/*/dist/cjs/index.cjs packages/turf/turf.min.js", | ||
| "lint:escheck-esm": "es-check --module es8 packages/*/dist/esm/index.js", | ||
| "lint:escheck-web": "es-check es5 packages/turf/turf.min.js", | ||
| "lint:eslint": "eslint packages", | ||
| "lint:eslint": "eslint --cache packages", | ||
| "lint:mrl": "mrl check", | ||
| "lint:prettier": "prettier --check .", | ||
| "lint:prettier": "prettier --cache --check .", | ||
| "preinstall": "npx only-allow pnpm", | ||
| "prepare": "husky && lerna run build", | ||
| "test": "pnpm run lint && lerna run test && lerna run --scope @turf/turf last-checks" | ||
| "prepack": "tsc -b ./tsconfig.cjs.json && tsx scripts/cjs-package-json.ts && pnpm run --filter @turf/turf rollup", | ||
| "prepare": "husky && tsc -b", | ||
| "prepublishOnly": "pnpm run lint && pnpm run escheck && pnpm run --filter @turf/turf last-checks", | ||
| "release": "pnpm run test:release && pnpm publish -r", | ||
| "test": "pnpm exec nx run-many -t test", | ||
| "test:release": "pnpm run lint && pnpm run escheck && pnpm run --filter @turf/turf last-checks", | ||
| "watch": "tsc -b --watch" | ||
| }, | ||
| "lint-staged": { | ||
| "package.json": [ | ||
|
|
@@ -22,7 +30,7 @@ | |
| "**/*.{js,ts}": [ | ||
| "eslint --fix" | ||
| ], | ||
| "packages/*/index.{js,ts}": [ | ||
| "packages/*/index.ts": [ | ||
| "node ./scripts/generate-readmes.mts", | ||
| "git add ./packages/*/README.md" | ||
| ], | ||
|
|
@@ -55,9 +63,10 @@ | |
| "lint-staged": "^15.5.1", | ||
| "load-json-file": "^7.0.1", | ||
| "meow": "^13.2.0", | ||
| "nx": "^22.7.1", | ||
| "prettier": "^3.5.3", | ||
| "progress": "^2.0.3", | ||
| "tsup": "^8.4.0", | ||
| "tsx": "^4.19.4", | ||
| "typescript": "^5.8.3", | ||
| "typescript-eslint": "^8.38.0", | ||
| "yaml": "^2.8.2" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.