Conversation
github-actions
bot
added
the
pr: new extension
|
you don't have to create a new PR each time you make a change. just push your commits (as in, making them appear on github. if you commit with the web gui this is done automatically) and it will automatically be updated |
oh, alr. Im new to this, everything seems so complex. Sorry |
There was a problem hiding this comment.
May I ask why you added this license in the root folder? It's not necessary...
| @@ -0,0 +1,547 @@ | |||
| // Name: Html Elements | |||
| // ID: htmlelements | |||
There was a problem hiding this comment.
ID should contain your username
| // ID: htmlelements | |
| // ID: samllea1HTMLElements |
|
|
||
| getInfo() { | ||
| return { | ||
| id: "htmlElements", |
There was a problem hiding this comment.
should also contain your username and match the ID above (case-sensitive)
| id: "htmlElements", | |
| id: "samllea1HTMLElements", |
| name: Scratch.translate({ | ||
| default: "HTML Elements", | ||
| id: "htmlElements.name", | ||
| }), |
There was a problem hiding this comment.
I don't believe I've ever seen the name of an extension have a structure like this, generally speaking shouldn't it just be a translated string?
| name: Scratch.translate({ | |
| default: "HTML Elements", | |
| id: "htmlElements.name", | |
| }), | |
| name: Scratch.translate("HTML Elements"), |
There was a problem hiding this comment.
This looks similar to how the core extensions handle translation but using Scratch.translate() instead of formatMessage(); Scratch generally uses IDs for string translation.
https://github.com/TurboWarp/scratch-vm/blob/develop/src/extensions/scratch3_translate/index.js#L105
There was a problem hiding this comment.
Generally the banner should be some sort of artistic representation of the purpose of your extension. Also, they shouldn't contain text as it can't easily be translated. Somebody will probably eventually make a "better" banner anyway so you might not have to worry about it but I would work on a placeholder banner without text.
|
sorry, been really busy. Im not really good with github ui so idk whats going on here but was my extension added? |
|
Nope, it still says "2 approving reviews are required by reviewers with write access" |
| { | ||
| opcode: "createInput", | ||
| blockType: Scratch.BlockType.COMMAND, | ||
| text: "create input with id [ID] at x: [X] y: [Y]", |
There was a problem hiding this comment.
block text should be translated
| text: "create input with id [ID] at x: [X] y: [Y]", | |
| text: Scratch.translate("create input with id [ID] at x: [X] y: [Y]"), |
| blockType: Scratch.BlockType.COMMAND, | ||
| text: "create input with id [ID] at x: [X] y: [Y]", | ||
| arguments: { | ||
| ID: { type: Scratch.ArgumentType.STRING, defaultValue: "input1" }, |
There was a problem hiding this comment.
Some string argument defaultValues probably should be translated
| ID: { type: Scratch.ArgumentType.STRING, defaultValue: "input1" }, | |
| ID: { type: Scratch.ArgumentType.STRING, defaultValue: Scratch.translate("input1") }, |
This and the comment above goes for all blocks.
| Y: { type: Scratch.ArgumentType.NUMBER, defaultValue: 0 }, | ||
| }, | ||
| }, | ||
| { blockType: Scratch.BlockType.LABEL, text: "Element Actions" }, |
There was a problem hiding this comment.
If your extension is large enough to have labels, I'd recommend using the block separators, but it's a personal preference.
| { blockType: Scratch.BlockType.LABEL, text: "Element Actions" }, | |
| "---", | |
| { blockType: Scratch.BlockType.LABEL, text: "Element Actions" }, |
|
Would it be okay of I tried to pick this up? The fixes seem simple and it seems as though the creator abandoned it, and later down the line I would like to add some new features, as this is exactly what I've been looking for. |
|
@snowboyz0825 you'd have to take it up with @samllea1, but since this is what open source is, I have no objections |
5 participants
No description provided.