Handle fractional macOS horizontal scroll deltas#198
Open
liuxuAP369 wants to merge 1 commit into
Open
Conversation
macOS can report Logitech horizontal tilt wheel movement as small fractional deltas. With the default threshold at 1, devices like the M720 require many tilt events before a mapped horizontal-scroll action fires, making desktop/browser mappings appear unresponsive. Lower the default threshold to the existing minimum effective value and allow saved integer thresholds to remain compatible with the float default. Constraint: Observed M720 macOS delta is about 0.100006 per tilt event Rejected: Device-specific M720 special case | other Logitech devices can emit the same fractional macOS wheel deltas Confidence: high Scope-risk: narrow Tested: python -m unittest tests.test_config tests.test_engine Not-tested: Full app GUI regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS can report Logitech horizontal tilt wheel movement as small fractional deltas. With the default threshold at 1, devices like the M720 require many tilt events before a mapped horizontal-scroll action fires, making desktop/browser mappings appear unresponsive. Lower the default threshold to the existing minimum effective value and allow saved integer thresholds to remain compatible with the float default.
Constraint: Observed M720 macOS delta is about 0.100006 per tilt event
Rejected: Device-specific M720 special case | other Logitech devices can emit the same fractional macOS wheel deltas
Confidence: high
Scope-risk: narrow
Tested: python -m unittest tests.test_config tests.test_engine
Not-tested: Full app GUI regression