New configuration option: 'per-feature-labels'#86
Open
APersonH wants to merge 3 commits into
Open
Conversation
…om yaml to csv. Still adds the original 'is-anomaly' row to csv.
Member
|
Hey @APersonH, nice idea 👍🏼 The changes look promising. Could you add tests for your new feature and also another example configuration in |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 90.28% 90.21% -0.07%
==========================================
Files 53 53
Lines 2120 2126 +6
==========================================
+ Hits 1914 1918 +4
- Misses 206 208 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option 'per-feature-labels' that can either be set in the yaml files to be either true or false, but is false by default. It works by adding a 'channel' variable to the LabelRange dataclass, and then, if the option is set, adds a new column to the output csv for each channel, specifying whether this channel is anomalous. The original 'is-anomaly' is found by taking the max of all per channel labels, and is still added to the csv in both cases.
This is very useful to have when trying to do explainability studies on anomaly detection algorithms.
This is my first pull request, please let me know if anything is missing, or there is additional things I need to deliver/do :-) (Or if I've something completely stupid)