fix(3505): Fixed panel tasks from regenerating values on subscription - #3515
Merged
Conversation
Also added a new Debounced Input component to make task creation not fire off every keystroke
alexanderson1993
approved these changes
Jun 30, 2026
| simulator | ||
| ? simulator.panels.map(p => { | ||
| const panel = App.softwarePanels.find(pp => (pp.id = p)); | ||
| const panel = App.softwarePanels.find(pp => pp.id === p); |
Member
There was a problem hiding this comment.
Oof. That's a silly bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When task subscriptions execute, the custom parts of the task that are autogenerated are regenerated, potentially causing a cascade of values every second.
This locks in the instructions when it is first generated, making it stay throughout resets/subscriptions, etc.
Related Issue
Resolves #3505
Screenshots (if appropriate):
feature on the Thorium Docs
repo. (Include the issue or pull request url below.)