refactor(settings): remove ineffective required

[aioya]

Summary

• remove the ineffective native required attribute from the built-in knowledge description input
• keep validation centralized in isEditingBuiltinConfigValid and the save guard
• avoid implying browser constraint validation in a dialog that does not submit through a form

UI

BEFORE

Description [ input: required attribute ]
             (no native form submission)
Save        [ disabled by computed validation ]

AFTER

Description [ input ]
Save        [ disabled by computed validation ]
             (save handler repeats the same guard)

No visual or behavior change.

Verification

• pnpm exec vitest run --config vitest.config.renderer.ts test/renderer/components/BuiltinKnowledgeSettings.test.ts (11 tests)
• pnpm run format:check
• pnpm run i18n
• pnpm run lint
• pnpm run typecheck

Summary by CodeRabbit

• Bug Fixes
  • Made the built-in knowledge description field optional, allowing users to save settings without entering a description.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 772a72f5-5ab9-475b-9704-e889acc82a8a

📥 Commits

Reviewing files that changed from the base of the PR and between 3873374 and aa7b99d.

📒 Files selected for processing (1)

• src/renderer/settings/components/BuiltinKnowledgeSettings.vue

💤 Files with no reviewable changes (1)

• src/renderer/settings/components/BuiltinKnowledgeSettings.vue

---

📝 Walkthrough

Walkthrough

The builtin knowledge description input no longer has the required attribute.

Changes

Cohort / File(s)	Summary
Builtin knowledge input src/renderer/settings/components/BuiltinKnowledgeSettings.vue	Removes the required attribute from the builtin knowledge description input.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the ineffective required attribute.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}