feat(mnemosyne): implement forget functionality across subsystems

[Theory903]

💡 What: Implemented the forget functionality in src/ippoc/mnemosyne/core.py and infra/src/mnemosyne/core.py.
🎯 Why: The method was stubbed with raise NotImplementedError, blocking removal of memories across subsystems.
📊 Impact: Completes the forget lifecycle for Episodic, Semantic, Procedural, and Graph memory subsystems.
🔬 Measurement: Added a comprehensive isolated test demonstrating forget aggregating subsystem results correctly without hitting external dependencies.

---

PR created automatically by Jules for task 9902071373020794638 started by @Theory903

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Expanded forget functionality to accept both single items and batch lists as inputs.
  • Improved handling of deletion confirmation responses for more reliable tracking.
  • Enhanced accuracy in memory relevance calculations.

• Documentation

  • Updated code examples with corrected import paths.
  • Clarified return type handling guidelines.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd698fd8-c42d-4c01-8cf2-798861af4f8c

📥 Commits

Reviewing files that changed from the base of the PR and between 29c13ba and c87c25b.

📒 Files selected for processing (3)

• .jules/sentinel.md
• infra/src/mnemosyne/core.py
• src/ippoc/mnemosyne/core.py

---

📝 Walkthrough

Walkthrough

The PR hardens MemorySystem.forget in both infra/src/mnemosyne/core.py and src/ippoc/mnemosyne/core.py to accept scalar strings (not just lists) for semantic.ids, procedural.skills, and graph.entities, normalizing them to single-element lists. The total_deleted accumulation is updated to branch on bool/int/truthy return types from each subsystem's delete method. The semantic search score is fixed to read from document metadata, the example import path is updated, and a sentinel log entry is added.

Changes

Forget Hardening and Semantic Score Fix

Layer / File(s)	Summary
Semantic score and import path fix infra/src/mnemosyne/core.py	Example import changed from mnemosyne to ippoc.mnemosyne; _search_semantic now reads retrieval_score from doc.metadata with a 1.0 default instead of a constant placeholder.
forget string normalization and return-type accumulation src/ippoc/mnemosyne/core.py, infra/src/mnemosyne/core.py	semantic.ids, procedural.skills, and graph.entities are coerced from string to single-element list before deletion. total_deleted now branches on bool/int/other-truthy return values from each subsystem's delete method, replacing previous fixed-count or len-based increments.
Sentinel log entry .jules/sentinel.md	New 2025-02-28 entry records the forget feature, the blocked optimization context, and guidance on bool vs int return type checks.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant MemorySystem
  participant SemanticStore
  participant ProceduralStore
  participant GraphStore

  Caller->>MemorySystem: forget(criteria)
  MemorySystem->>MemorySystem: normalize str→[str] for ids/skills/entities
  MemorySystem->>SemanticStore: delete_memories(semantic_ids)
  SemanticStore-->>MemorySystem: bool | int | other
  MemorySystem->>MemorySystem: total_deleted += count from bool/int/truthy
  MemorySystem->>ProceduralStore: delete_skill(skill) per skill
  ProceduralStore-->>MemorySystem: bool | int | other
  MemorySystem->>MemorySystem: total_deleted += count from bool/int/truthy
  MemorySystem->>GraphStore: delete_entity(entity) per entity
  GraphStore-->>MemorySystem: int | truthy
  MemorySystem->>MemorySystem: total_deleted += int value or 1
  MemorySystem-->>Caller: total_deleted

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Theory903/open-ippoc#30: Directly modifies MemorySystem.forget deletion orchestration and total_deleted counting logic in the same core.py files.
• Theory903/open-ippoc#39: Implements forget functionality across all subsystems in the same infra/src/mnemosyne/core.py and src/ippoc/mnemosyne/core.py files.

Poem

A bunny once tried to make memories fade,
But strings slipped through cracks the old logic had made.
Now bool, int, or truthy — each counts its own toll,
A single item list plays its rightful role.
🐇✨ Forget is now flexible, sturdy, and whole!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description lacks mandatory sections from the template including Intent Declaration, Canon Compliance, Scope Control, IPPOC-FS Contract Compliance, Boundary Declaration, Safety & Evolution Impact, and Final Assertion.	Complete the IPPOC-OS Pull Request Template by filling in all seven mandatory sections, including organ affected, change type, file/concept modifications, docstring compliance, external API usage, and safety considerations.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and directly summarizes the main change: implementing forget functionality across memory subsystems.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jules-9902071373020794638-bd02416c

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}