Skip to content

feat(mnemosyne): implement forget functionality across subsystems #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Theory903 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(mnemosyne): implement forget functionality across subsystems #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions infra/src/mnemosyne/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,12 @@ async def forget(self, criteria: Dict[str, Any]) -> int:
semantic_criteria = criteria["semantic"]
if "ids" in semantic_criteria:
semantic_ids = semantic_criteria["ids"]
if isinstance(semantic_ids, str):
semantic_ids = [semantic_ids]
if semantic_ids:
if await self.semantic.delete_memories(semantic_ids):
total_deleted += len(semantic_ids)
res = await self.semantic.delete_memories(semantic_ids)
if res:
total_deleted += len(semantic_ids) if type(res) is bool else (res if type(res) is int else 1)
except Exception as e:
logger.error(f"Failed to delete semantic memories: {e}")

Expand All @@ -332,9 +335,12 @@ async def forget(self, criteria: Dict[str, Any]) -> int:
proc_criteria = criteria["procedural"]
if "skills" in proc_criteria:
skills = proc_criteria["skills"]
if isinstance(skills, str):
skills = [skills]
for skill_name in skills:
if await self.procedural.delete_skill(skill_name):
total_deleted += 1
res = await self.procedural.delete_skill(skill_name)
if res:
total_deleted += 1 if type(res) is bool else (res if type(res) is int else 1)
except Exception as e:
logger.error(f"Failed to delete procedural skills: {e}")

Expand All @@ -344,9 +350,11 @@ async def forget(self, criteria: Dict[str, Any]) -> int:
graph_criteria = criteria["graph"]
if "entities" in graph_criteria:
entities = graph_criteria["entities"]
if isinstance(entities, str):
entities = [entities]
for entity in entities:
count = await self.graph.delete_entity(entity)
total_deleted += count if isinstance(count, int) else (1 if count else 0)
total_deleted += count if type(count) is int else (1 if count else 0)
except Exception as e:
logger.error(f"Failed to delete graph entities: {e}")

Expand Down
18 changes: 13 additions & 5 deletions src/ippoc/mnemosyne/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,12 @@ async def forget(self, criteria: Dict[str, Any]) -> int:
semantic_criteria = criteria["semantic"]
if "ids" in semantic_criteria:
semantic_ids = semantic_criteria["ids"]
if isinstance(semantic_ids, str):
semantic_ids = [semantic_ids]
if semantic_ids:
if await self.semantic.delete_memories(semantic_ids):
total_deleted += len(semantic_ids)
res = await self.semantic.delete_memories(semantic_ids)
if res:
total_deleted += len(semantic_ids) if type(res) is bool else (res if type(res) is int else 1)
except Exception as e:
logger.error(f"Failed to delete semantic memories: {e}")

Expand All @@ -332,9 +335,12 @@ async def forget(self, criteria: Dict[str, Any]) -> int:
proc_criteria = criteria["procedural"]
if "skills" in proc_criteria:
skills = proc_criteria["skills"]
if isinstance(skills, str):
skills = [skills]
for skill_name in skills:
if await self.procedural.delete_skill(skill_name):
total_deleted += 1
res = await self.procedural.delete_skill(skill_name)
if res:
total_deleted += 1 if type(res) is bool else (res if type(res) is int else 1)
except Exception as e:
logger.error(f"Failed to delete procedural skills: {e}")

Expand All @@ -344,9 +350,11 @@ async def forget(self, criteria: Dict[str, Any]) -> int:
graph_criteria = criteria["graph"]
if "entities" in graph_criteria:
entities = graph_criteria["entities"]
if isinstance(entities, str):
entities = [entities]
for entity in entities:
count = await self.graph.delete_entity(entity)
total_deleted += count if isinstance(count, int) else (1 if count else 0)
total_deleted += count if type(count) is int else (1 if count else 0)
except Exception as e:
logger.error(f"Failed to delete graph entities: {e}")

Expand Down
Loading