Clean up stdexec-only paths and update affected tests by guptapratykshh · Pull Request #7123 · TheHPXProject/hpx

guptapratykshh · 2026-03-28T05:53:16Z

Proposed Changes

removedHPX_HAVE_STDEXECguarded cleanup paths and kept the stdexec-only implementation as the single active path
update the affected execution, execution_base, executor, algorithm, async MPI/CUDA, and synchronization tests to match the unified stdexec-only code path
cleared up related CMake/stdexec configuration so the build reflects the same single-path setup consistently

Any background context you want to provide?

Checklist

Not all points below apply to all pull requests.

I have added a new feature and have added tests to go along with it.
I have fixed a bug and have added a regression test.
I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

StellarBot · 2026-03-28T05:55:03Z

Can one of the admins verify this patch?

hkaiser · 2026-03-28T11:11:50Z

@isidorostsa Please have a look

hkaiser · 2026-03-28T14:28:31Z

BTW, how does this relate to #6708? Does this PR superseds it?

hkaiser · 2026-03-28T14:29:24Z

@guptapratykshh thanks for working on this. Could you please proactively keep an eye on the CI results. Currently there seem to be some compilation issues with this PR.

guptapratykshh · 2026-03-28T14:36:57Z

BTW, how does this relate to #6708? Does this PR superseds it?

this PR is a narrower follow up in the same direction as #6708, updated on top of the current master rather than a wholesale replacement for it. It keeps the stdexec-only cleanup goal, but its scope here is mainly removing the remaining dead internal paths and fixing the resulting test issues while preserving backward compatibility.

hkaiser · 2026-03-28T14:56:35Z

BTW, how does this relate to #6708? Does this PR superseds it?

this PR is a narrower follow up in the same direction as #6708, updated on top of the current master rather than a wholesale replacement for it. It keeps the stdexec-only cleanup goal, but its scope here is mainly removing the remaining dead internal paths and fixing the resulting test issues while preserving backward compatibility.

Thanks for the explanations. Do we still need #6708? What does it have in addition to your PR?

guptapratykshh · 2026-03-28T15:15:49Z

BTW, how does this relate to #6708? Does this PR superseds it?

this PR is a narrower follow up in the same direction as #6708, updated on top of the current master rather than a wholesale replacement for it. It keeps the stdexec-only cleanup goal, but its scope here is mainly removing the remaining dead internal paths and fixing the resulting test issues while preserving backward compatibility.

Thanks for the explanations. Do we still need #6708? What does it have in addition to your PR?

after merging #6708 into my branch and updating it to work with current master, I do not think we still need #6708 as separate PR

hkaiser · 2026-03-28T15:34:34Z

Thanks for the explanations. Do we still need #6708? What does it have in addition to your PR?

after merging #6708 into my branch and updating it to work with current master, I do not think we still need #6708 as separate PR

Ok, please let me know once you think that we can close the other PR.

isidorostsa

Thank you for taking on this task! Removing old senders would be helpful

To make it possible to review this please contain unnecessary or pedantic edits as much as possible.

Copilot

Pull request overview

Copilot reviewed 147 out of 167 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 147 out of 168 changed files in this pull request and generated 1 comment.

Signed-off-by: guptapratykshh <[email protected]>

Copilot

Pull request overview

Copilot reviewed 147 out of 167 changed files in this pull request and generated 1 comment.

…exec PR#2035) Signed-off-by: guptapratykshh <[email protected]>

hkaiser · 2026-04-21T18:53:12Z

@guptapratykshh Thanks so much for your patience with this. This PR is very large, so it is of utmost importance to separate all unrelated changes into their own PRs. Please make sure that the changes to the build system you applied are strictly related to this PR. I think you should not disable unrelated tests, even if those fail on the CIs, for instance. Also, please pay attention to the copilot comments (and not simply resolve them) as usually there is some truth to what it suggest (even if the suggested solution might not be appropriate).

hkaiser · 2026-04-21T18:58:08Z

-    test_uninitialized_copy_n_sender(
-        hpx::launch::async, par(task), IteratorTag());
-    test_uninitialized_copy_n_sender(
-        hpx::launch::async, par_unseq(task), IteratorTag());


Why did you remove these test cases?

These tests are still removed. Will you re-add them?

those test cases were re-added in commit 974334220d

hkaiser · 2026-04-21T18:58:22Z

-    test_uninitialized_copy_n_exception_sender(
-        hpx::launch::async, par(task), IteratorTag());
-    test_uninitialized_copy_n_exception_sender(
-        hpx::launch::async, par_unseq(task), IteratorTag());


Same here, why did you remove these testcases. The same applies to more places in other files.

Same here, these tests are still removed. Will you re-add them? So are many more tests below.

those test cases were re-added in commit 974334220d

Signed-off-by: guptapratykshh <[email protected]>

Copilot

Pull request overview

Copilot reviewed 141 out of 160 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

libs/core/execution_base/tests/unit/CMakeLists.txt:1

This change skips registering all execution_base unit tests when using Clang/AppleClang. That’s a large reduction in CI signal for those toolchains and may hide regressions unrelated to the specific warning/ICE being worked around. Prefer targeting only the failing tests (e.g. list(REMOVE_ITEM ...) for known problematic sources) or adding per-target compile options/diagnostic suppression instead of disabling the entire test directory for Clang.

# Copyright (c) 2019 Thomas Heller

Signed-off-by: guptapratykshh <[email protected]>

…leClang<=17 Signed-off-by: guptapratykshh <[email protected]>

Copilot

Pull request overview

Copilot reviewed 142 out of 161 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

cmake/templates/std_headers.hpp.in:1

This change removes the HPX_HAVE_STDEXEC guard and now unconditionally emits #pragma ... diagnostic pop (Clang) and a push+pop block (GCC). For Clang in particular, a diagnostic pop without a matching earlier push commonly triggers warnings/errors. Please ensure the pragmas are correctly paired (either reintroduce the guard, add the missing push, or avoid emitting pop when no push has been issued).

//  Copyright (c) 2019-@HPX_COPYRIGHT_YEAR@ STE||AR Group

Signed-off-by: guptapratykshh <[email protected]>

hkaiser

Let's go ahead with merging this PR as all tests seem to pass.

hkaiser · 2026-05-03T15:20:10Z

@guptapratykshh Thank you again for your work on this. I have now merged this PR, however we should keep an eye on how things evolve.

guptapratykshh requested a review from hkaiser as a code owner March 28, 2026 05:53

guptapratykshh force-pushed the cleanup/stdexec-pr branch 4 times, most recently from 7ca8cbe to a24be1a Compare March 28, 2026 08:45

hkaiser added category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals type: enhancement type: compatibility issue type: cleanup labels Mar 28, 2026

guptapratykshh force-pushed the cleanup/stdexec-pr branch from c180673 to 82b73f8 Compare March 28, 2026 15:31

guptapratykshh force-pushed the cleanup/stdexec-pr branch 8 times, most recently from 3863598 to 62d14bc Compare March 29, 2026 13:59

isidorostsa suggested changes Mar 29, 2026

View reviewed changes

guptapratykshh force-pushed the cleanup/stdexec-pr branch 3 times, most recently from 49ba52e to d94eaf8 Compare March 30, 2026 13:29

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 20, 2026 07:26

guptapratykshh force-pushed the cleanup/stdexec-pr branch from 4e3595b to d8193f7 Compare April 20, 2026 07:26

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread libs/core/execution/tests/unit/CMakeLists.txt Outdated

Copilot AI review requested due to automatic review settings April 20, 2026 11:50

guptapratykshh force-pushed the cleanup/stdexec-pr branch from 63b569e to 32683b8 Compare April 20, 2026 11:50

remove stdexec::tags re-export (namespace removed from upstream stdexec)

8b4f6fc

Signed-off-by: guptapratykshh <[email protected]>

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread libs/core/execution_base/tests/unit/CMakeLists.txt

remove stdexec digit separator patching (fixed upstream in NVIDIA/std…

ff262f9

…exec PR#2035) Signed-off-by: guptapratykshh <[email protected]>

guptapratykshh requested a review from hkaiser April 21, 2026 09:16

hkaiser reviewed Apr 21, 2026

View reviewed changes

revert unrelated changes, restore tests, add compiler versions

9743342

Signed-off-by: guptapratykshh <[email protected]>

Copilot AI review requested due to automatic review settings April 21, 2026 20:27

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread libs/core/execution_base/include/hpx/execution_base/this_thread.hpp

Comment thread cmake/HPX_SetupStdexec.cmake

guptapratykshh added 2 commits April 22, 2026 09:43

set up Stdexec unconditionally

98e25f3

Signed-off-by: guptapratykshh <[email protected]>

restore HPX_HAVE_STDEXEC define, bump foreach_report exclusion to App…

8da4996

…leClang<=17 Signed-off-by: guptapratykshh <[email protected]>

Copilot AI review requested due to automatic review settings April 22, 2026 06:00

Copilot AI reviewed Apr 22, 2026

View reviewed changes

fix foreach_report exclusion to use VERSION_LESS to cover patch releases

68a1953

Signed-off-by: guptapratykshh <[email protected]>

hkaiser approved these changes Apr 29, 2026

View reviewed changes

hkaiser added this to the 2.0.0 milestone Apr 29, 2026

isidorostsa mentioned this pull request Apr 30, 2026

execution: fix split scheduler preservation for late subscribers (P2300) #7165

Closed

hkaiser mentioned this pull request May 3, 2026

Implement P2300 bulk adapter for HPX executors #7240

Open

3 tasks

This was referenced May 3, 2026

Assume HPX_HAVE_STDEXEC #6708

Closed

drop dead trait, dead test guards, and migrate async_mpi receiver to native P2300 #7244

Merged

This was referenced May 4, 2026

CMake developer warning regarding fetching Stdexec #7245

Closed

Transition SR tag_invoke to member functions #6709

Closed

Copilot AI mentioned this pull request May 4, 2026

make_future: isolate __loop_ private-member access in single detail helper #7247

Merged

Uh oh!

Conversation

guptapratykshh commented Mar 28, 2026

Proposed Changes

Any background context you want to provide?

Checklist

Uh oh!

StellarBot commented Mar 28, 2026

Uh oh!

hkaiser commented Mar 28, 2026

Uh oh!

hkaiser commented Mar 28, 2026

Uh oh!

hkaiser commented Mar 28, 2026

Uh oh!

guptapratykshh commented Mar 28, 2026

Uh oh!

hkaiser commented Mar 28, 2026

Uh oh!

guptapratykshh commented Mar 28, 2026

Uh oh!

hkaiser commented Mar 28, 2026

Uh oh!

isidorostsa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

hkaiser commented Apr 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hkaiser Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

hkaiser Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

guptapratykshh Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

hkaiser Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

hkaiser Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

guptapratykshh Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!