Skip to content

Fix heap-use-after-free in PrimaDelayCalc copy constructor #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maliberty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix heap-use-after-free in PrimaDelayCalc copy constructor #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dcalc/PrimaDelayCalc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ PrimaDelayCalc::PrimaDelayCalc(StaState *sta) :
PrimaDelayCalc::PrimaDelayCalc(const PrimaDelayCalc &dcalc) :
DelayCalcBase(dcalc),
pin_node_map_(network_),
node_index_map_(dcalc.node_index_map_),
// node_index_map_ is intentionally not copied. Its keys are raw
// ParasiticNode* whose pointees may already be freed when this copy is made
// (parasitic networks are rebuilt during repair), and copying the map would
// dereference them via the ParasiticNodeLess comparator. It is transient
// state rebuilt by findNodeCount() before any read.
prima_order_(dcalc.prima_order_),
watch_pin_values_(network_),
table_dcalc_(makeDmpCeffElmoreDelayCalc(this))
Expand Down