odb: encapsulate inst module assignment#10819
Open
naveenvenk17 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request encapsulates the module_ member variable of _dbInst by making it private and introducing getter and setter methods (getModuleId, setModule, and setModuleQuiet). The setModule method handles triggering the inDbPostInstParentChange callback when an instance's parent module changes. Consequently, direct accesses and modifications to module_ across dbBlock.cpp, dbInst.cpp, and dbModule.cpp have been updated to use these new encapsulated methods. Additionally, a new helper function rebuildDbInstModuleHash was introduced in dbBlock.cpp to reconstruct the instance module hash map. There are no review comments, so I have no feedback to provide.
Fixes The-OpenROAD-Project#10282 Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
4908c75 to
791b8fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_dbInsthelper methods instead of directmodule_writesinDbPostInstParentChangewhen an instance is reparented between modulesTests
bazelisk build --jobs=4 --local_cpu_resources=4 //src/odb/src/db:dbbazelisk test --jobs=4 --local_cpu_resources=4 //src/dbSta/test:sdc_modinst_slash-tcl_teston the Ubuntu 22.04 GCP VM fails before test execution while linkingopenroadwith unresolved__isoc23_*glibc symbols from the Bazel LLVM/sysroot toolchain.