Skip to content

bazel: pass git to lint scripts in fix_lint #10813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 2 commits into from
Jul 6, 2026
+17 −5
Merged

bazel: pass git to lint scripts in fix_lint #10813

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a9a30
bazel: pass git to lint scripts in fix_lint
oharboe Jul 4, 2026
e72a1c9
bazel: name fix_lint.sh parameters
oharboe Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,7 @@ sh_binary(
"$(rootpath @buildifier_prebuilt//:buildifier)",
"$(rootpath //bazel:bzl_lint_test.sh)",
"$(rootpath @buildifier_prebuilt//:buildifier)",
"$(rootpath @git)",
],
data = [
"MODULE.bazel",
Expand All @@ -677,5 +678,6 @@ sh_binary(
"//bazel:tclfmt",
"//bazel:tclint",
"@buildifier_prebuilt//:buildifier",
"@git",
],
)
4 changes: 2 additions & 2 deletions bazel/fix_lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ export BUILD_WORKSPACE_DIRECTORY="${BUILD_WORKSPACE_DIRECTORY:-$PWD}"

# TCL: auto-format then lint
"$1" "$2"
"$3" "$4" || rc=$?
"$3" "$4" "$9" || rc=$?
Comment thread
oharboe marked this conversation as resolved.
Outdated
Comment thread
oharboe marked this conversation as resolved.
Outdated

# Bazel: auto-format then lint
"$5" "$6"
"$7" "$8" || rc=$?
"$7" "$8" "$9" || rc=$?

git -C "$BUILD_WORKSPACE_DIRECTORY" status
Comment thread
oharboe marked this conversation as resolved.
Outdated

Expand Down
Loading