dpl/dpo: properly load fixed instances orientation#10793
Conversation
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates Opendp::improvePlacement to adjust the orientation of all cell nodes, including fixed ones, and introduces a debug pause and log message before initializing the ShiftLegalizer. It also changes the drawing color from white to orange in Graphics::drawObjects. There are no review comments, so no additional feedback is provided.
|
I am running a secure-CI at: https://jenkins.openroad.tools/blue/organizations/jenkins/OpenROAD-flow-scripts-Private/detail/secure-dpl-dpo-load-macro-flipping/4/pipeline I am not sure if we have flipped macros on our designs, if we do this may imply functional modifications. |
osamahammad21
left a comment
There was a problem hiding this comment.
Merge iff no secure-ci impact.
|
With the user's reproducible I see the issue being solved nicely. Although I don't yet understand why we see differences in secure-CI. I did not observe an incorrectly flipped macro as I did with the user's design. I wish to understand this before merging. I suspect it is just some small fixed instances with incorrect flipping. I will investigate. |
Summary
The introduction of the pixels grid to DPO required painting and the initialization of instances orientation, which was performed at PR #10267. Although it was done skipping fixed instances. I see no reason to skip them, it even introduces issues to flipped macros, such as in issue #10677 which has a flipped macro on input ODB.
This PR excludes the skipping of fixed macros when initializing the orientation of instances for DPO.
Type of Change
Impact
Properly initialize fixed instances orientation at DPO.
Verification
./etc/Build.sh).Related Issues
This PR solves the 4 reproducibles at #10677