changes to accomodate for new changes in OpenSTA 6/30 pulling latest

[dsengupta0628]

Summary

Update OpenSTA The-OpenROAD-Project/OpenSTA#379

1. change hasSequential to isSequential as former is deprecated
2. regolden zerosoc_pad.tcl as the iteration max is now changed and this was a non-converging activity propagation regression anyways
3. upstream changed sta::scenes to return Scene objects instead of name strings. So OpenROAD's src/est/src/EstimateParasitics.tcl needed to be updated to not use string-interpolated $corner into the EST-0018 warning like utl::warn EST 18 "wire capacitance for corner [get_name $corner] is zero...

Type of Change

• New feature

Impact

Power.cc changed to have one extra iteration count for activity propagation
cleanup · parallaxsw/OpenSTA@c81f0c1 and line in Power::ensureActivities (power/Power.cc):

  -  while (!regs.empty() && pass < max_activity_passes_) {
  +  while (!regs.empty() && pass <= max_activity_passes_) {

This change causes one extra activity-propagation pass (50 instead of 49; max_activity_passes_ = 50).
I regoldened one failing regression but this can drift power in some designs where activity propagation is not well behaved.

Verification

• I have verified that the local build succeeds (./etc/Build.sh).
• I have run the relevant tests and they pass.
• My code follows the repository's formatting guidelines.
• I have signed my commits (DCO).

[gemini-code-assist]

Code Review

This pull request replaces the usage of hasSequentials() with isSequential() on LibertyCell objects across various source files to align with API updates. Additionally, it updates EstimateParasitics.tcl to use get_name for the corner variable in a warning message, updates the src/sta subproject commit, and adjusts a test expectation file. I have no feedback to provide.

[dsengupta0628]

secure CI https://jenkins.openroad.tools/view/all/job/OpenROAD-flow-scripts-Private/job/secure-or_update_sta_latest_0629/

[jhkim-pii]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: f4e5e40f47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[dsengupta0628]

Secure-CI and public-CI are both clean actually