Skip to content

fix: preload options name shoule be the only required property #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colgin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: preload options name shoule be the only required property #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/preloadApp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ type preOptions {
/** 唯一性用户必须保证 */
name: string;
/** 需要渲染的url */
url: string;
url?: string;
/** 注入给子应用的数据 */
props?: { [key: string]: any };
/** 自定义iframe属性 */
Expand Down
6 changes: 3 additions & 3 deletions packages/wujie-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ type baseOptions = {
loadError?: loadErrorHandler;
};

export type preOptions = baseOptions & {
/** 预执行 */
exec?: boolean;
export type preOptions = Partial<baseOptions> & {
/** 唯一性用户必须保证 */
name: string;
};

export type startOptions = baseOptions & {
Expand Down