Port compat to 26.1.x#2624
Conversation
GizmoTheMoonPig
left a comment
GizmoTheMoonPig
left a comment
There was a problem hiding this comment.
For future reference, if you dont know what youre doing with the build.gradle, please ask. Things are set up the way they are for a reason, a lot of the changes you made there should not have happened.
| IElementHelper helper = IElementHelper.get(); | ||
| int total = data.getInt("total"); | ||
| tooltip.add(helper.text(Component.translatable("jade.drying_rack.remaining", RecipeViewerConstants.getDryingTime(total - progress))).translate(new Vec2(10.0F, 0.0F))); | ||
| int progress = data.getInt("progress").orElseThrow(); |
There was a problem hiding this comment.
do not throw here. Use getIntOr for all the tag checks, defaulting to 0 if they dont exist
| CompoundTag tag = rack.saveWithoutMetadata(accessor.getLevel().registryAccess()); | ||
| data.putInt("progress", tag.getInt("dry_time")); | ||
| data.putInt("total", tag.getInt("total_dry_time")); | ||
| data.putInt("progress", tag.getInt("dry_time").orElseThrow()); |
|
|
||
| //make sure to only pick one of these when testing (switch others to compileOnly) | ||
| // implementation "mezz.jei:jei-${project.minecraft_version}-neoforge:${project.jei_version}" | ||
| // implementation "mezz.jei:jei-26.1.2-neoforge:${project.jei_version}" |
There was a problem hiding this comment.
why are you hardcoding versions here? Use the gradle properties like we were before
|
|
||
| //curse maven | ||
| // implementation "curse.maven:jade-324717:6170888" | ||
| // implementation "maven.modrinth:jade:${project.minecraft_version}+neoforge" |
There was a problem hiding this comment.
why are you switching to the modrinth maven? The CF one works fine, keep using that.
New version for 26.1 is 324717:8251883. You can also uncomment the line so the jade source is actually added to the workspace
|
|
||
| // theillusivec4 | ||
| // implementation "top.theillusivec4.curios:curios-neoforge:${project.curios_version}+${project.base_minecraft_version}" | ||
| // implementation "top.theillusivec4.curios:curios-neoforge:${project.curios_version}+26.1.2" |
| maven { | ||
| name = "OctoStudios" //Curios | ||
| url = uri("https://maven.octo-studios.com/releases") | ||
| repositories { |
There was a problem hiding this comment.
why is there an extra repositories block here?
Do you mind if I DM you on Discord? I have a few questions about the build script and I think that's probably more efficient. |
2 participants
Feel free to review this, but I would not recommend merging until the main source set gets ported. I updated the Jade compat and some of the dependencies, but the recipe and curios compat may depend on other PRs from me or Albazavr.