Port recipes to 26.1.x#2611
Open
a6tumn wants to merge 18 commits into
Open
Conversation
Merged
Author
|
Feels best to leave this here for the time being. Going to mark as ready for review so I can get some feedback. |
Andromander
reviewed
Jun 9, 2026
| @Override | ||
| public RecipeSerializer<?> getSerializer() { | ||
| return TFRecipes.UNCRAFTING_SERIALIZER.get(); | ||
| public RecipeSerializer<ShapedRecipe> getSerializer() { |
Member
There was a problem hiding this comment.
Just to quickly check, is it possible to use ? extends ShapedRecipe to avoid the casting?
Author
There was a problem hiding this comment.
Unfortunately it errors. I think the type is just very strict here for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a TODO in my previous PR regarding TFRecipes. The main goal here is switching to the new codec serialization system for recipes rather than using nested Serializer classes. It also deals with the removal of SimpleCraftingRecipeSerializer.
Notes:
PS: Sorry for the messy diff in NoTemplateSmithingRecipe, I moved some things around.