Update Rust crate reqwest to 0.13.0#433
Conversation
|
4325ba7 to
09d743e
Compare
09d743e to
2160a60
Compare
6e5c953 to
f273f10
Compare
f8b9b73 to
be1b95e
Compare
1fbffd4 to
08d9d1a
Compare
78d8922 to
ef927a9
Compare
8e9a9da to
2a08536
Compare
2a08536 to
983a48b
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e6582e7 to
1216375
Compare
c37f5c3 to
2d16578
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Cargo.toml`:
- Line 14: The reqwest dependency line uses the removed feature name
"rustls-tls"; update the features array for reqwest (the dependency entry
starting with reqwest = { version = "0.13.0", ... }) to replace "rustls-tls"
with the new feature name "rustls" so the features list reads ... features =
["rustls", "gzip", "json", "socks"] ... ensuring dependency resolution succeeds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| redis = { version = "0.29.0", default-features = false, features = ["tokio-comp", "connection-manager"] } | ||
| regex = "1.10.4" | ||
| reqwest = { version = "0.12.4", default-features = false, features = ["rustls-tls", "gzip", "json", "socks"] } | ||
| reqwest = { version = "0.13.0", default-features = false, features = ["rustls-tls", "gzip", "json", "socks"] } |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
In reqwest 0.13.x, was the Cargo feature rustls-tlsrenamed torustls, and is rustls-tls still accepted or removed? Please cite the official reqwest changelog/docs.
💡 Result:
Yes. In reqwest 0.13.0 the Cargo feature rustls-tls was renamed to rustls. (raw.githubusercontent.com)
In reqwest 0.13.x, rustls-tls is not a defined feature anymore (the crate’s [features] list includes rustls / rustls-no-provider, but no rustls-tls), so depending on reqwest = { version = "0.13", features = ["rustls-tls"] } will fail with “feature not found”. (raw.githubusercontent.com)
Citations:
- 1: https://raw.githubusercontent.com/seanmonstar/reqwest/v0.13.0/CHANGELOG.md
- 2: https://raw.githubusercontent.com/seanmonstar/reqwest/v0.13.2/Cargo.toml
Change rustls-tls to rustls in reqwest 0.13.0 features to fix the build break.
The rustls-tls feature was renamed to rustls in reqwest 0.13.0 and the old name is no longer available. Using rustls-tls will cause dependency resolution to fail with "feature not found".
Fix
-reqwest = { version = "0.13.0", default-features = false, features = ["rustls-tls", "gzip", "json", "socks"] }
+reqwest = { version = "0.13.0", default-features = false, features = ["rustls", "gzip", "json", "socks"] }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| reqwest = { version = "0.13.0", default-features = false, features = ["rustls-tls", "gzip", "json", "socks"] } | |
| reqwest = { version = "0.13.0", default-features = false, features = ["rustls", "gzip", "json", "socks"] } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Cargo.toml` at line 14, The reqwest dependency line uses the removed feature
name "rustls-tls"; update the features array for reqwest (the dependency entry
starting with reqwest = { version = "0.13.0", ... }) to replace "rustls-tls"
with the new feature name "rustls" so the features list reads ... features =
["rustls", "gzip", "json", "socks"] ... ensuring dependency resolution succeeds.
076f0a1 to
aae9371
Compare
aae9371 to
0a1aade
Compare
0a1aade to
3edcb42
Compare
200d756 to
948dd72
Compare
948dd72 to
69faf4e
Compare
This PR contains the following updates:
0.12.4→0.13.0Release Notes
seanmonstar/reqwest (reqwest)
v0.13.3Compare Source
/etc/resolv.conffails.STOP_SENDINGas not an error.v0.13.2Compare Source
RequestBuilder::json()from override previously set content-type.v0.13.1Compare Source
v0.13.0Compare Source
rustlsis now the default TLS backend, instead ofnative-tls.rustlscrypto provider defaults to aws-lc instead of ring. (rustls-no-providerexists if you want a different crypto provider)rustls-tlshas been renamed torustls.rustls-platform-verifieris used by default.tls_certs_only(your_roots).native-tlsnow includes ALPN. To disable, usenative-tls-no-alpn.queryandformare now crate features, disabled by default.trust-dns, which was renamedhickory-dnsa while ago).tls_backend_rustls()overuse_rustls_tls().v0.12.28
v0.12.27
ClientBuilder::windows_named_pipe(name)option that will force all requests over that Windows Named Piper.v0.12.26
Accept-Encodingheader only with values configured with reqwest, regardless of underlying tower-http config.v0.12.25
Error::is_upgrade()to determine if the error was from an HTTP upgrade.Proxy-Authorizationif only username is configured.Proxy-Authorizationto HTTPS proxies when the target is HTTP.v0.12.24
v0.12.23
ClientBuilder::unix_socket(path)option that will force all requests over that Unix Domain Socket.ClientBuilder::retry(policy)andreqwest::retry::Builderto configure automatic retries.ClientBuilder::dns_resolver2()with more ergonomic argument bounds, allowing more resolver implementations.http3_*options toblocking::ClientBuilder.RequestBuilder.v0.12.22
v0.12.21
socks4a://instead ofsocks4h://.Error::is_timeout()to check for hyper and IO timeouts too.Errorto again include URLs when possible.DefaultforBody.v0.12.20
ClientBuilder::tcp_user_timeout(Duration)option to setTCP_USER_TIMEOUT.Error::is_status().v0.12.19
cookiesfeature is enabled (by the way, it's a noop feature in wasm).v0.12.18
socksenabled without TLS.v0.12.17
v0.12.16
ClientBuilder::http3_congestion_bbr()to enable BBR congestion control.ClientBuilder::http3_send_grease()to configure whether to send use QUIC grease.ClientBuilder::http3_max_field_section_size()to configure the maximum response headers.ClientBuilder::tcp_keepalive_interval()to configure TCP probe interval.ClientBuilder::tcp_keepalive_retries()to configure TCP probe count.Proxy::headers()to add extra headers that should be sent to a proxy.redirect::Policy::limit()which had an off-by-1 error, allowing 1 more redirect than specified.Response::bytes_stream().v0.12.15
ProxyOverrideandNO_PROXY.v0.12.14
fetch_mode_no_cors(), marking as deprecated when not on WASM.v0.12.13
Form::into_reader()for blockingmultipartforms.Form::into_stream()for asyncmultipartforms.RequestBuilder::form()from overwriting a previously setContent-Typeheader, like the other builder methods.blocking::Request.ProxyOverrideas aNO_PROXYvalue.Error::is_timeout()to return true when from a request timeout.v0.12.12
tokio/timeon WASM.v0.12.11
v0.12.10
ClientBuilder::connector_layer()to allow customizing the connector stack.ClientBuilder::http2_max_header_list_size()option.content-length) information when wrapping bodies.v0.12.9
tls::CertificateRevocationListssupport.connection_verbose()to output read logs.multipart::Part::file()to automatically include content-length.v0.12.8
multipart::Form::file()method for adding files easily.Body::wrap()to wrap anyhttp_body::Bodytype.v0.12.7
impl Service<http::Request<_>>forClient.v0.12.6
danger_accept_invalid_hostnamesforrustls.impl Service<http::Request<Body>>forClientand&'_ Client.!Syncbodies inBody::wrap_stream().hickory-dnsis used.Proxyso thatHTTP(S)_PROXYvalues take precedence overALL_PROXY.blocking::RequestBuilder::header()from unsettingsensitiveon passed header values.v0.12.5
blocking::ClientBuilder::dns_resolver()method to change DNS resolver in blocking client.http3feature back, still requiringreqwest_unstable.rustls-tls-no-providerCargo feature to use rustls without a crypto provider.Accept-Encodingheader combinations.v0.12.4
zstdsupport, enabled withzstdCargo feature.ClientBuilder::read_timeout(Duration), which applies the duration for each read operation. The timeout resets after a successful read.v0.12.3
FromStrfordns::Name.ClientBuilder::built_in_webpki_certs(bool)to enable them separately.ClientBuilder::built_in_native_certs(bool)to enable them separately.content-length: 0for GET requests.content_length()to return value when timeout is configured.ClientBuilder::resolve()to use lowercase domain names.v0.12.2
v0.12.1
ClientBuilder::interface()when no TLS is enabled.TlsInfo::peer_certificate()being truncated with rustls.http2feature disabled but TLS negotiated h2 in ALPN.DisplayforErrorto not include its source error.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.