Conversation
|
@theimpulson please checkout the new changes with the |
| activity?.let { | ||
| if (it.isTaskRoot) { | ||
| it.startActivity( | ||
| Intent(it, MainActivity::class.java).apply { |
There was a problem hiding this comment.
I am not sure but won't this keep looping back and forth in case of crash when ErrorActivity is launched by acra?
There was a problem hiding this comment.
You're right, that could cause an infinite loop. I've removed it. The crash loop I was seeing during testing was actually caused by the comments screen crashing again on return (no-internet handling), not by this code. I'll fix that in a subsequent pr.
Thank you, looks good to me other than some minor nitpicks and questions on places where I am unsure about the behavior. |
I think all are resolved now |
What is it?
Description of the changes in your PR
Converted ErrorActivity from Android Views to Jetpack Compose. The XML layout and menu are replaced by a Compose screen with all the same sections: error message, device info, stack trace details, user comment field, and report/share actions. The privacy policy dialog was also converted to Compose so it survives rotation and renders correctly with Material 3 theming. A shared BaseActivity was introduced to provide edge-to-edge display and Compose theme setup, serving as the foundation for future activity migrations.
Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence