Fix search not working in drawer category views

[geoffreysisco]

Description

Drawer categories (Quick Access, Recent Files, Images, Videos, Audio,
Documents, APKs, and Trash Bin) do not represent real filesystem
directories. Instead, they display an in-memory list of visible items.

The existing search flow always used BasicSearch, which expects a
filesystem path and searches the underlying filesystem. As a result,
searches from drawer category views either returned no results or did not
search the visible dataset being displayed to the user.

This change introduces ListElementsSearch, which searches the currently
visible listElements dataset. Searches launched from
OpenMode.CUSTOM and OpenMode.TRASH_BIN now use this in-memory search
path, while normal filesystem locations continue using BasicSearch.

The search UI was also updated to hide deep/indexed search options in
drawer category views where filesystem-based search modes do not apply.

Issue tracker

Fixes #4561

Automatic tests

• Added test cases

Manual tests

• Done

Device: Pixel 9 Pro (emulator)
OS: Android 16 (API 36)
Rooted: No
Build: debug

Verified search in:

• Recent Files
• Images
• Videos
• Audio
• Documents
• APKs
• Trash Bin
• Normal directory view

Could not verify:

• Quick Access (no items available to search)

Build tasks success

Successfully running following tasks locally:

• ./gradlew assembleDebug
• ./gradlew spotlessCheck

[VishnuSanal]

awesome, LGTM 🚀 thanks for contributing to amaze :)

[geoffreysisco]

Adding before/after recordings for clarity:

Before (search fails in drawer/category views)

After (search uses visible dataset)

Repro:

1. Open a drawer category (e.g. Images)
2. Tap search
3. Enter test
4. Press search

Expected:
Matching visible files are returned

Actual (before):
No results returned

[EmmanuelMess]

This should follow the structure of the normal search, and launch to a different coroutine. It also misses the other search modes (index and deep), which should probably be disabled completely in some CUSTOM modes.

[geoffreysisco]

Thanks, that makes sense.

I see the issue — this is currently handling CUSTOM / TRASH_BIN inline inside basicSearch() instead of following the existing search structure.

I’ll revisit this and rework it to align more closely with the normal search pattern.

[geoffreysisco]

I pushed an updated implementation that follows the normal search structure more closely.

Instead of handling CUSTOM / TRASH_BIN inline inside basicSearch(), these modes now use a dedicated FileSearch implementation (ListElementsSearch) while keeping the existing coroutine / LiveData search pipeline intact.

Indexed and deep search escalation are also disabled for these views since they do not support filesystem-backed search modes.

Added focused ListElementsSearch unit tests covering:

• matching visible drawer items
• filtering back/header entries
• no-result behavior

Quick Access remains unverified (no items available to test), as noted in the original description.

[geoffreysisco]

Pushed another small cleanup/refinement pass on the new ListElementsSearch test coverage.

This follow-up mainly focused on test maintainability and static-analysis cleanup:

• extracted repeated literals into shared constants

• added behavior-focused documentation/comments for each test case

• clarified the expected behavior around:

  • matching visible items
  • filtering back/header entries
  • no-result publication behavior

No functional behavior changes in this push — primarily readability, maintainability, and test clarity improvements around the dataset-backed search implementation.