Skip to content

chore(types): re-export SearchMiddleware type from react-router#7087

Open
jameshoward wants to merge 1 commit intoTanStack:mainfrom
jameshoward:patch-1
Open

chore(types): re-export SearchMiddleware type from react-router#7087
jameshoward wants to merge 1 commit intoTanStack:mainfrom
jameshoward:patch-1

Conversation

@jameshoward
Copy link
Copy Markdown

@jameshoward jameshoward commented Apr 1, 2026

Re-export SearchMiddleware from @tanstack/router-core in @tanstack/react-router to avoid needing to add a direct dependency on @tanstack/router-core when typing search middleware.

Summary by CodeRabbit

  • New Features
    • Added SearchMiddleware type to public exports, allowing developers to import and use this type directly from the package.

Re-export `SearchMiddleware` from `@tanstack/router-core` in `@tanstack/react-router` to avoid needing to add a direct dependency on `@tanstack/router-core` when typing search middleware.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4623ad2e-60a0-4339-92fe-b04db2f9c974

📥 Commits

Reviewing files that changed from the base of the PR and between 5a81726 and d31d214.

📒 Files selected for processing (1)
  • packages/react-router/src/index.tsx

📝 Walkthrough

Walkthrough

The pull request adds SearchMiddleware to the public type exports in the react-router package's main entry point, re-exporting it from @tanstack/router-core. This makes the type available directly to consumers of the package.

Changes

Cohort / File(s) Summary
Type Export
packages/react-router/src/index.tsx
Added SearchMiddleware to the public re-exports from @tanstack/router-core.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A type hops into view,
Through exports, fresh and new,
SearchMiddleware takes its place,
In the public space,
One small line, but it's true! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: re-exporting the SearchMiddleware type from react-router package to simplify consumer dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Bundle Size Benchmarks

  • Commit: 5a81726f0a2f
  • Measured at: 2026-04-01T08:19:08.104Z
  • Baseline source: history:796406da66cf
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.48 KiB 0 B (0.00%) 275.76 KiB 75.97 KiB ████▁▁▁▁▁▂▃
react-router.full 90.78 KiB 0 B (0.00%) 286.95 KiB 78.95 KiB ▆▆▆█▁▁▁▁▁▂▂
solid-router.minimal 35.56 KiB 0 B (0.00%) 107.26 KiB 31.94 KiB ████▁▁▁▁▁▂█
solid-router.full 40.03 KiB 0 B (0.00%) 120.79 KiB 35.94 KiB ████▁▁▁▁▁▂▆
vue-router.minimal 53.38 KiB 0 B (0.00%) 153.07 KiB 47.94 KiB ████▁▁▁▁▁▂▄
vue-router.full 58.25 KiB 0 B (0.00%) 168.53 KiB 52.18 KiB ████▁▁▁▁▁▂▄
react-start.minimal 102.01 KiB 0 B (0.00%) 324.00 KiB 88.21 KiB ▅▅▅█▁▂▂▂▂▃▃
react-start.full 105.38 KiB 0 B (0.00%) 334.35 KiB 91.14 KiB ▆▆▆█▁▁▁▂▂▃▃
solid-start.minimal 49.66 KiB 0 B (0.00%) 153.51 KiB 43.84 KiB ▇▇▇▇▁▁▁▂▂▂█
solid-start.full 55.17 KiB 0 B (0.00%) 169.74 KiB 48.46 KiB ▇▇▇▇▁▂▂▂▂▃█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant