fix descriptions of targetOwner and originOwner predicates in JavaAccess#1603
Merged
StefanGraeber merged 1 commit intoMay 18, 2026
Merged
Conversation
StefanGraeber
force-pushed
the
fix-access-owner-predicate-descriptions
branch
3 times, most recently
from
960e3d6 to
ffe067a
Compare
StefanGraeber
force-pushed
the
fix-access-owner-predicate-descriptions
branch
from
ffe067a to
759c85a
Compare
hankem
approved these changes
May 10, 2026
targetOwner and originOwner() were producing the same message as target() and origin() e.g. "access target where target is annotated with..." instead of "access target where target owner is annotated with..." The existing test is also updated to assert that the correct element is passed to the given predicate, for which new testUtils are introduced. Signed-off-by: Stefan Gräber <stefan.graeber@tngtech.com>
StefanGraeber
force-pushed
the
fix-access-owner-predicate-descriptions
branch
from
759c85a to
52d6874
Compare
Contributor
Author
|
@wakingrufus this PR is merged now. thanks again for your original PR #1579 finding the issue 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
targetOwner and originOwner() were producing the same message as target() and origin() e.g. "access target where target is annotated with..." instead of "access target where target owner is annotated with..." The existing test is also updated to assert that the correct element is passed to the given predicate, for which new testUtils are introduced.
replacement for #1579