Bridge preferred codecs and key systems to the Android SDK - #882
Draft
GillesMoris-Dolby wants to merge 4 commits into
Draft
Bridge preferred codecs and key systems to the Android SDK#882GillesMoris-Dolby wants to merge 4 commits into
GillesMoris-Dolby wants to merge 4 commits into
Conversation
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bridges two Android SDK source configuration properties that the TypeScript API declares (or now declares) but the Android bridge did not pass through:
TypedSource.abr(new API, mirrors the Web SDK):preferredVideoCodecsandpreferredAudioCodecslet an app steer track selection towards a codec family (e.g.["dvh1", "hvc1"]) on mixed-codec ladders. The Android bridge maps it onto the SDK'sSourceDescription.abr; on Web the source description is passed through and handled natively.contentProtection.preferredKeySystems: already part of the TypeScript API, but silently dropped by the Android bridge. It is now parsed and passed to the SDK'sDRMConfiguration, so Android honors the configured key system order (e.g. preferring PlayReady over Widevine).iOS requires no equivalent change (AVPlayer owns track selection and FairPlay is the only key system).
Dependency
Both properties require the upcoming THEOplayer Android SDK release (11.8.0) that introduces
SourceAbrConfiguration.preferred*CodecsandDRMConfiguration.preferredKeySystems. The SDK version range[11.5.0, 12.0.0)already covers it, but CI will not compile the Android module until that release is published — hence draft. Validated locally against a locally publishedcore:11.8.0build (internal branchfeature/dolby-preference, commitb8e833a2699).Note:
preferredKeySystemsis bridged for the custom-integration/default DRM path; pre-integration configurations (Axinom, DRMToday, ...) deserialize via Gson and are unchanged.Test plan
npm run typescript,npm run lint,npm run prettier:react-native-theoplayer:compileDebugKotlin, resolvedcore:[11.5.0, 12.0.0) -> 11.8.0from mavenLocal)abr.preferredVideoCodecsandpreferredKeySystemssetGenerated with Devin