Revert `FileWriter`/`FileWriteResult` by YoshiRulz · Pull Request #4716 · TASEmulators/BizHawk

revert intervening changes to `MovieZone.cs`

YoshiRulz

committed

Revert "Handle file errors when saving a macro."

YoshiRulz

committed

Revert "Handle errors when saving config file."

YoshiRulz

committed

revert intervening changes to `LuaConsole.cs`

YoshiRulz

committed

Revert "Handle file writing errors for movies and all tools."

YoshiRulz

committed

Revert "Fix: CheatList was getting forcibly autosaved, after the method that properly checks the autosave config option."

YoshiRulz

committed

Revert "Handle SRAM saving failure."

YoshiRulz

committed

Revert "Move stuff around to make more sense for ask-user-about-saving-or-canceling flow even though not all asking and error handling is implemented yet. Also, fix: respect the cancel button."

YoshiRulz

committed

revert intervening changeset 2 to `IMainFormForTools.cs`

YoshiRulz

committed

revert intervening changeset 1 to `IMainFormForTools.cs`

YoshiRulz

committed

Revert "Update comments, rename method, and remove obsolete things."

YoshiRulz

committed

Revert "Handle most errors related to savestate files. Autosave last slot is still broken on close and on TAStudio open."

YoshiRulz

committed

Revert "Add support for backup files in FileWriter and better error reporting."

YoshiRulz

committed

Revert "Handle exceptions while writing a movie file, and use a temporary file until writing has completed. Avoids crashing and prevents loss of data in the event of an exception mid-write."

YoshiRulz

committed

reapply intervening changeset 1 to `IMainFormForTools.cs`

YoshiRulz

committed

reapply intervening changeset 2 to `IMainFormForTools.cs`

YoshiRulz

committed

reapply intervening changes to `LuaConsole.cs`

YoshiRulz

committed

reapply intervening changes to `MovieZone.cs`

YoshiRulz

committed

reapply intervening changeset 2 to `TAStudio.MenuItems.cs`

YoshiRulz

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert `FileWriter`/`FileWriteResult`#4716

Revert `FileWriter`/`FileWriteResult`#4716
YoshiRulz wants to merge 23 commits into
masterfrom
revert-filewriter

Commits on Apr 28, 2026

Revert "Fix `CheatList.SaveFile` returning success without writing anything"

Revert "Improve `DialogControllerExtensions.DoWithTryAgainBox` dialog"

Revert "Fix `FileWriter.Create` choking on relative paths"

revert intervening changeset 2 to `TAStudio.MenuItems.cs`

Commits on Apr 29, 2026

revert intervening changes to `MovieZone.cs`

Revert "Handle file errors when saving a macro."

Revert "Handle errors when saving config file."

revert intervening changes to `LuaConsole.cs`

Revert "Handle file writing errors for movies and all tools."

Revert "Fix: CheatList was getting forcibly autosaved, after the method that properly checks the autosave config option."

Revert "Handle SRAM saving failure."

Revert "Move stuff around to make more sense for ask-user-about-saving-or-canceling flow even though not all asking and error handling is implemented yet. Also, fix: respect the cancel button."

revert intervening changeset 2 to `IMainFormForTools.cs`

revert intervening changeset 1 to `IMainFormForTools.cs`

Revert "Update comments, rename method, and remove obsolete things."

Revert "Handle most errors related to savestate files. Autosave last slot is still broken on close and on TAStudio open."

Revert "Add support for backup files in FileWriter and better error reporting."

Revert "Handle exceptions while writing a movie file, and use a temporary file until writing has completed. Avoids crashing and prevents loss of data in the event of an exception mid-write."

reapply intervening changeset 1 to `IMainFormForTools.cs`

reapply intervening changeset 2 to `IMainFormForTools.cs`

reapply intervening changes to `LuaConsole.cs`

reapply intervening changes to `MovieZone.cs`

reapply intervening changeset 2 to `TAStudio.MenuItems.cs`