Add --game-list option to specify a file with filter regexes#288
Open
kblaschke wants to merge 1 commit intoSude-:masterfrom
Open
Add --game-list option to specify a file with filter regexes#288kblaschke wants to merge 1 commit intoSude-:masterfrom
kblaschke wants to merge 1 commit intoSude-:masterfrom
Conversation
2085d0e to
f198169
Compare
The --game option will override the list as it's a more specific filter. This allows to configure the list globally in the config file while still using --game to download a single game via the command line.
f198169 to
5eb8989
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --game option will override the list as it's a more specific filter. This allows to configure the list globally in the config file while still using --game to download a single game via the command line.
With this change, the regexes are also only compiled once before filtering.
I went with a similar logic as it is applied with the --game option for the list file:
To download all games without a filter while having a filter file specified in the config, users can simply reset it to an empty filename, e.g.
lgogdownloader --game-list "".Fixes issue #267