feat(chart): optional HorizontalPodAutoscaler and PodDisruptionBudget#37
Open
rcarvalhoxavier wants to merge 1 commit intoStirling-Tools:mainfrom
Open
feat(chart): optional HorizontalPodAutoscaler and PodDisruptionBudget#37rcarvalhoxavier wants to merge 1 commit intoStirling-Tools:mainfrom
rcarvalhoxavier wants to merge 1 commit intoStirling-Tools:mainfrom
Conversation
…dget Signed-off-by: Rodrigo Xavier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoscaling/v2) targeting the main Deployment, driven byvalues.autoscaling(disabled by default).policy/v1) with the same selector labels as the Deployment, driven byvalues.podDisruptionBudget(disabled by default).values.yaml.Motivation
Downstream deployments often need HPA and PDB next to the chart. Shipping them as opt-in templates avoids maintaining parallel manifests and keeps labels/selectors consistent with
stirlingpdf.selectorLabels.Notes
targetMemoryUtilizationPercentageis set to a value > 0.maxUnavailableor rely onminAvailable(default1whenmaxUnavailableis unset).helm template test . --set autoscaling.enabled=true --set podDisruptionBudget.enabled=true.