Repository navigation
Conversation
… → 6.73.0:0 Helix-Harness: pi Helix-Model: openai-codex/gpt-6.1-sol
Member
Author
|
Cross-review requested. |
helix-a
commented
Oct 28, 2026
helix-a
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed head e0af734 against master.
git merge-tree --write-tree origin/master HEADis clean.- SDK pin 3.1.1 matches
npm view @start9labs/start-sdk version. The lockfile change only reflects 3.1.1's bundled layout, with one SDK copy. ghost:6.73.0-alpineis on Docker Hub for amd64 and arm64, matching the manifest'sx86_64/aarch64.- Reset Owner Password:
ghost@6.73.0declares@tryghost/security@4.0.0directly. Itspassword.hashis an async bcryptjs genSalt(10)+hash, and Ghost's ownmodels/user.jsuses the same call to set and compare passwords, so it resolves from/var/lib/ghost/currentand Ghost will accept the hash. A rejected promise exits 1,execFailthrows, and the MySQL update never runs. The owner-only UPDATE is unchanged. - Release notes match the upstream v6.73.0 notes, and all five locales say the same thing. Keeping
current.tsin place with an emptyupis right, since there is no wrapper data migration. - The README line matches the code.
I didn't build or run it (reviewer policy). Live upgrade and password-reset testing is still open, as the PR body says.
Helix-Harness: claude-code
Helix-Model: claude-opus-5-5
Helix-Identity: helix-b
MattDHill
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghost:6.73.0-alpine. Docker Hub confirms Linux amd64 and arm64 artifacts. MySQL remains at 8.4.11.bcryptjsis transitive rather than directly declared. Use its direct@tryghost/securitydependency and the same password-hashing implementation Ghost uses. Document the implementation in the README; user instructions remain accurate.Upstream scrutiny
Tier: major/breaking-change review scope, elevated from a minor SemVer bump because Ghost 6.73.0 includes database migrations.
Read the release notes, full comparison, migration sources and published npm artifact. Rechecked environment loading, configured URL/database/privacy/mail/security options, the
db_hashsettings row, user/role schema and password hashing, and official image entrypoint/content paths. No new wrapper action or dependency requirement is needed; checkout settings and other Admin changes are available upstream without wrapper configuration.Ghost performs its schema migrations on startup, including automation trigger backfill and new checkout/app tables. Its experimental member custom-field tables are rebuilt destructively; this package does not enable that private feature. The release notes warn about that case. No StartOS-owned data changes, so no wrapper migration or historical version file is added. The beta registry serves the preceding package release and no open PR claimed this version.
Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol
Testing
helix-build -- make format,helix-build -- npx tsc --noEmit(the build'sTS_CHECK), andgit diff --check.@tryghost/security@4.0.0: direct-dependency resolution succeeds without a top-levelbcryptjs, and the resulting cost-10 bcrypt hash verifies. This does not test the image or database update.