Skip to content

Fix: generatePKCECodeVerifier length #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ADmad merged 3 commits into from
Aug 28, 2025
Merged

Fix: generatePKCECodeVerifier length #199

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a29858c
- Fixes generatePKCECodeVerifier() to never generate strings < 43 or …
mlabas-ixopay Aug 27, 2025
a34c276
Space
mlabas-ixopay Aug 27, 2025
5dbe1c8
Rename length to byteLength
mlabas-ixopay Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/OAuth2/AbstractProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ abstract class AbstractProvider extends AbstractBaseProvider

protected bool $pkce = false;

protected int $pkceCodeVerifierLength = 96;

@ADmad ADmad Aug 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to pkceCodeVerifierByteLength to be more clear about what length it indicates?

@harphield harphield Aug 28, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that will make it more understandable. I also renamed it in the generatePKCECodeVerifier method.


/**
* @return string
*/
Expand All @@ -50,7 +52,7 @@ public function getAuthUrlParameters(): array
$parameters['response_type'] = 'code';

if ($this->pkce) {
$codeVerifier = $this->generatePKCECodeVerifier();
$codeVerifier = $this->generatePKCECodeVerifier($this->pkceCodeVerifierLength);
$this->session->set('code_verifier', $codeVerifier);

$parameters['code_challenge'] = $this->generatePKCECodeChallenge($codeVerifier);
Expand All @@ -60,10 +62,12 @@ public function getAuthUrlParameters(): array
return $parameters;
}

private function generatePKCECodeVerifier(int $length = 128)
private function generatePKCECodeVerifier(int $length = 96): string
{
if ($length < 43 || $length > 128) {
throw new \Exception("Length must be between 43 and 128");
if ($length < 32 || $length > 96) {
throw new \Exception(
"Final length must be between 43 and 128, so the number of random bytes must be between 32 and 96"
);
}

$randomBytes = random_bytes($length);
Expand Down