Fix: Adjust laser work area when quickswap modules are installed#2609
Open
rmcc wants to merge 1 commit into
Open
Fix: Adjust laser work area when quickswap modules are installed#2609rmcc wants to merge 1 commit into
rmcc wants to merge 1 commit into
Conversation
Commit e772f09 adds support for quickswap-related area size adjustments, but only applies them to FDM printing. Make equivalent adjustments in the laser tools to avoid objects being placed outside the work area and getting cut off when those coordinates are unreachable, by clamping the max dimensions of a job setup to an area that includes the module-related offsets.
rmcc
force-pushed
the
fix-laser-size-with-quickswap
branch
from
364ac53 to
55c65e2
Compare
Author
|
New version of this: now it just clamps the max area you can use to set up a new job, replicating exactly the manual behavior people have to use with 4.15.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit e772f09 adds support for quickswap-related area size adjustments, but only applies them to FDM printing.
Make equivalent adjustments in the laser tools to avoid objects being placed outside the work area and getting cut off when those coordinates are unreachable.