Skip to content

Add version consistency check#12

Closed
PrincessStevenson (PrincessStevenson) wants to merge 1 commit into
mainfrom
turbolift-version-consistency-check-company-wide-v1
Closed

Add version consistency check#12
PrincessStevenson (PrincessStevenson) wants to merge 1 commit into
mainfrom
turbolift-version-consistency-check-company-wide-v1

Conversation

@PrincessStevenson

@PrincessStevenson PrincessStevenson (PrincessStevenson) commented Apr 7, 2026

Copy link
Copy Markdown

What

This PR adds a standalone Version Consistency Check workflow to the repository.

It runs Skyscanner/version-consistency-check@v1 as a separate check in GitHub so version mismatches show up clearly on the PR.

The check is configured to fail when inconsistencies are found.

Why

This introduces language version mismatch checks in the repository.

It is part of the strategic action for INL-3290 / INC-4850 and is outlined in COMET-2757.

The check looks for mismatched build and runtime language versions across repository configuration, workflow setup, and Dockerfiles where supported.

References

Testing

Not run locally. Workflow change only.

Request

As the owning squad, please review and merge.

This PR was generated using turbolift.

Copilot AI review requested due to automatic review settings April 7, 2026 19:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated GitHub Actions workflow to run Skyscanner’s version consistency check so language/runtime version mismatches surface as a distinct PR check.

Changes:

  • Introduces a new Version Consistency Check workflow triggered on pushes and PRs targeting main
  • Runs Skyscanner/version-consistency-check configured to fail the job when inconsistencies are detected

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

contents: read
runs-on: ubuntu-latest-small
steps:
- uses: actions/checkout@v6

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow references actions/checkout by a moving tag (@v6). To reduce supply-chain risk and prevent unexpected behavior changes, pin this action to a specific commit SHA (optionally using GitHub’s dependabot/action update tooling to manage upgrades).

Suggested change
- uses: actions/checkout@v6
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332

Copilot uses AI. Check for mistakes.
persist-credentials: false

- name: Check Version Consistency
uses: Skyscanner/version-consistency-check@v1

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skyscanner/version-consistency-check@v1 is referenced by a moving major tag. For reproducible builds and to reduce supply-chain risk, consider pinning to a specific commit SHA (and updating intentionally when you want new behavior).

Suggested change
uses: Skyscanner/version-consistency-check@v1
uses: Skyscanner/version-consistency-check@<FULL_40_CHARACTER_COMMIT_SHA_FOR_THE_APPROVED_V1_REVISION>

Copilot uses AI. Check for mistakes.
@PrincessStevenson

Copy link
Copy Markdown
Author

Closing this rollout PR because we should not use the internal version-consistency-check action in public repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants