Add version consistency check#12
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to run Skyscanner’s version consistency check so language/runtime version mismatches surface as a distinct PR check.
Changes:
- Introduces a new
Version Consistency Checkworkflow triggered on pushes and PRs targetingmain - Runs
Skyscanner/version-consistency-checkconfigured to fail the job when inconsistencies are detected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| contents: read | ||
| runs-on: ubuntu-latest-small | ||
| steps: | ||
| - uses: actions/checkout@v6 |
There was a problem hiding this comment.
The workflow references actions/checkout by a moving tag (@v6). To reduce supply-chain risk and prevent unexpected behavior changes, pin this action to a specific commit SHA (optionally using GitHub’s dependabot/action update tooling to manage upgrades).
| - uses: actions/checkout@v6 | |
| - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 |
| persist-credentials: false | ||
|
|
||
| - name: Check Version Consistency | ||
| uses: Skyscanner/version-consistency-check@v1 |
There was a problem hiding this comment.
Skyscanner/version-consistency-check@v1 is referenced by a moving major tag. For reproducible builds and to reduce supply-chain risk, consider pinning to a specific commit SHA (and updating intentionally when you want new behavior).
| uses: Skyscanner/version-consistency-check@v1 | |
| uses: Skyscanner/version-consistency-check@<FULL_40_CHARACTER_COMMIT_SHA_FOR_THE_APPROVED_V1_REVISION> |
|
Closing this rollout PR because we should not use the internal version-consistency-check action in public repos. |
What
This PR adds a standalone
Version Consistency Checkworkflow to the repository.It runs Skyscanner/version-consistency-check@v1 as a separate check in GitHub so version mismatches show up clearly on the PR.
The check is configured to fail when inconsistencies are found.
Why
This introduces language version mismatch checks in the repository.
It is part of the strategic action for INL-3290 /
INC-4850and is outlined in COMET-2757.The check looks for mismatched build and runtime language versions across repository configuration, workflow setup, and Dockerfiles where supported.
References
action.ymlTesting
Not run locally. Workflow change only.
Request
As the owning squad, please review and merge.
This PR was generated using turbolift.