Fix JPEG SIMD slicing and padding length handling. #3105
Merged
JimBobSquarePants merged 1 commit intomainfrom Apr 7, 2026
Merged
Fix JPEG SIMD slicing and padding length handling. #3105JimBobSquarePants merged 1 commit intomainfrom
JimBobSquarePants merged 1 commit intomainfrom
Conversation
JimBobSquarePants
added a commit
that referenced
this pull request
Apr 7, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #3104
This PR fixes a potential access violation in the AVX2
Rgb24unpack path used by JPEG encoding.UnpackToRgbPlanesAvx2Reduceprocesses 8Rgb24pixels per iteration (24 bytes), but the AVX2 path begins with a 32-byte vector load. On unpadded rows, the final vectorized iteration could therefore read past the end of the source row even though the logical span length checks passed, which matches the crash reported in #3104.The fix reduces the AVX2 loop count so we only vectorize chunks that still have the 3-pixel slack required by that 32-byte load. Any remaining pixels are left to the existing scalar tail path.